Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message that workflows feature is experimental #812

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Sep 11, 2024

🚀 This description was created by Ellipsis for commit d3cc645

Summary:

Added an experimental feature alert in Workflows.tsx for empty workflows on the first page, with a demo booking link.

Key points:

  • Added experimental feature alert in skyvern-frontend/src/routes/workflows/Workflows.tsx.
  • Alert shown when workflows list is empty and workflowsPage is 1.
  • Utilizes Alert, AlertTitle, and AlertDescription components.
  • Includes ExclamationTriangleIcon and a demo booking link.

Generated with ❤️ by ellipsis.dev

…src/'

<!-- ELLIPSIS_HIDDEN -->

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 58e218db8d302b9e42af29ad5783445017bfb22f  |
|--------|--------|

### Summary:
Added an experimental feature alert in `Workflows.tsx` for empty workflows on the first page, with a demo booking link.

**Key points**:
- Added an experimental feature alert in `skyvern-frontend/src/routes/workflows/Workflows.tsx`.
- Alert is shown when `workflows` list is empty and `workflowsPage` is 1.
- Utilizes `Alert`, `AlertTitle`, and `AlertDescription` components.
- Includes `ExclamationTriangleIcon` and a link to book a demo.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
@ykeremy ykeremy added the sync label Sep 11, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d3cc645 in 13 seconds

More details
  • Looked at 59 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/Workflows.tsx:168
  • Draft comment:
    The ml-auto class is unnecessary here as it doesn't affect the layout. Consider removing it for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of the 'ml-auto' class in the anchor tag is unnecessary since the link is not part of a flex or grid container where 'ml-auto' would have an effect. It should be removed for cleaner code.

Workflow ID: wflow_9benqGhsZRAqh2Ui


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d3cc645 in 26 seconds

More details
  • Looked at 58 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/Workflows.tsx:168
  • Draft comment:
    The ml-auto class is unnecessary here as it doesn't affect the layout in this context. Consider removing it.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of the 'ml-auto' class in the anchor tag is unnecessary since the link is not part of a flex or grid container where it would be needed to push the link to the end of the container.

Workflow ID: wflow_xnB2iDFjrJ9eLEc4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 2c3e285 into main Sep 11, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/workflows-experimental-message branch September 11, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants