Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better context for select and auto-complete #816

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Sep 12, 2024

🚀 This description was created by Ellipsis for commit 3bd0d2d

feat: improve context handling for auto-completion and selection actions

Summary:

Enhance context handling for auto-completion and selection actions by updating prompt templates and action models to include field information and required status.

Key points:

  • Prompts:
    • Update context in auto-completion-choose-option.j2, auto-completion-potential-answers.j2, auto-completion-tweak-value.j2, and custom-select.j2 to use field_information.
    • Add required_field context in custom-select.j2.
  • Models:
    • Add field_information and required_field to Action class in actions.py.
  • Handlers:
    • Update handle_input_text_action() and handle_select_option_action() in handler.py to pass field_information and required_field to actions.
    • Modify choose_auto_completion_dropdown() and input_or_auto_complete_input() to use field_information in prompts.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 3bd0d2d in 55 seconds

More details
  • Looked at 226 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_If0mGaLFLQhKwPd3


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -45,6 +45,8 @@ def __repr__(self) -> str:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure field_information and required_field are included in all action instantiations for consistency. This applies to other actions like TerminateAction, CompleteAction, NullAction, and SolveCaptchaAction.

@LawyZheng LawyZheng merged commit f16b6f3 into main Sep 12, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/better-select-context branch September 12, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant