SendEmailBlock: Fail silently if file/folder is missing #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Update `SendEmailBlock` to log a warning for missing files or directories instead of raising an error, ensuring smoother email sending. > > - **Behavior**: > - Update `_get_file_paths` in `SendEmailBlock` to log a warning if a file or directory is missing instead of raising an error. > - Handles paths that are URLs or S3 URIs separately, ensuring they are added to `file_paths` if valid. > - **Logging**: > - Adds a warning log for missing files or directories in `_get_file_paths`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 6b1c5b609f14f473b80586c2b212f5b12ceac486. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f2d619c in 8 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:891
- Draft comment:
Consider including more context in the warning message, such as the workflow_run_id, to aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The logging message for missing files or directories should include more context for better debugging.
Workflow ID: wflow_waxLnVfwBql9FUNo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f2d619c in 11 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:891
- Draft comment:
The logging statement for missing files or directories should include more context, such as the workflow_run_id, to aid in debugging. Consider addingworkflow_run_id=workflow_run_idto the log statement. - Reason this comment was not posted:
Confidence changes required:50%
The PR description indicates that missing files or directories should log a warning instead of raising an error. The code change reflects this, but there is a potential issue with the logging statement.
Workflow ID: wflow_mCZF6tha2AHqOUgN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ykeremy
deleted the
ykeremy/send-email-block-silently-warn-file-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
SendEmailBlockto log warnings for missing files or directories instead of raising errors, ensuring smoother email sending._get_file_pathsinSendEmailBlockto log a warning if a file or directory is missing instead of raising an error.file_pathsif valid._get_file_paths.This description was created by
for f2d619c. It will automatically update as commits are pushed.