-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context parameters in UI #902
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add support for context parameters in the workflow editor UI, including new components and refactoring for improved parameter and node label handling. > > - **Behavior**: > - Add `SourceParameterKeySelector` component for selecting context and output parameter keys. > - Support context parameters in `WorkflowParameterAddPanel` and `WorkflowParameterEditPanel`. > - Update `FlowRenderer` to handle context parameters in `convertToParametersYAML()`. > - **Node Handling**: > - Refactor node label change handling using `useNodeLabelChangeHandler` hook. > - Update nodes like `CodeBlockNode`, `DownloadNode`, `FileParserNode`, etc., to use the new label change handler. > - **Parameter Management**: > - Add context parameter type to `ParametersState` in `FlowRenderer`. > - Update `WorkflowParametersPanel` to manage context parameters. > - **Utilities**: > - Add `getUpdatedParametersAfterLabelUpdateForSourceParameterKey()` in `workflowEditorUtils`. > - Refactor `HorizontallyResizingInput` to use `ComponentPropsWithoutRef`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b83dcfc423379b99c008c4121cbc594ea0c0ed27. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6d31312 in 29 seconds
More details
- Looked at
1129
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:724
- Draft comment:
The return statement should usenewOutputParameterKey
instead ofoldOutputParameterKey
to correctly update the parameter with the new label.
: parameter.sourceParameterKey,
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_j7HC9t2k9bOT4jrV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6d31312 in 47 seconds
More details
- Looked at
1129
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:725
- Draft comment:
The return statement should usenewOutputParameterKey
instead ofoldOutputParameterKey
when thesourceParameterKey
matchesoldOutputParameterKey
. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:650
- Draft comment:
TheconvertEchoParameters
function should handleContextParameter
to ensure context parameters are echoed back correctly. - Reason this comment was not posted:
Marked as duplicate.
3. skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx:70
- Draft comment:
Useparameter.sourceParameterKey
instead ofparameter.source.key
to access the source parameter key. - Reason this comment was not posted:
Marked as duplicate.
4. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:89
- Draft comment:
Ensuresource_parameter_key
is set fromparameter.sourceParameterKey
forContextParameter
. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_VGAbvq3N02felLPS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add support for context parameters in the workflow editor UI, including new components and refactoring for improved parameter and node label handling.
SourceParameterKeySelector
component for selecting context and output parameter keys.WorkflowParameterAddPanel
andWorkflowParameterEditPanel
.FlowRenderer
to handle context parameters inconvertToParametersYAML()
.useNodeLabelChangeHandler
hook.CodeBlockNode
,DownloadNode
,FileParserNode
, etc., to use the new label change handler.ParametersState
inFlowRenderer
.WorkflowParametersPanel
to manage context parameters.getUpdatedParametersAfterLabelUpdateForSourceParameterKey()
inworkflowEditorUtils
.HorizontallyResizingInput
to useComponentPropsWithoutRef
.This description was created by for 6d31312. It will automatically update as commits are pushed.