Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code block from node list #913

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Oct 5, 2024

Important

Temporarily removes the 'Code Block' node from nodeLibraryItems in WorkflowNodeLibraryPanel.tsx, which executed Python code.

  • Behavior:
    • Temporarily removes the 'Code Block' node from nodeLibraryItems in WorkflowNodeLibraryPanel.tsx.
    • The 'Code Block' node was responsible for executing Python code.

This description was created by Ellipsis for 91639d2. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Temporarily removes the 'Code Block' node from `WorkflowNodeLibraryPanel.tsx`.
>
>   - **Behavior**:
>     - Temporarily removes the 'Code Block' node from `nodeLibraryItems` in `WorkflowNodeLibraryPanel.tsx`.
>     - The 'Code Block' node was responsible for executing Python code.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for fc1b9d0227e99035da282f6c1d33885225ee28a9. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
@ykeremy ykeremy added the sync label Oct 5, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 91639d2 in 5 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:3
  • Draft comment:
    The CodeIcon import is no longer needed and can be removed since the Code Block is commented out.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for CodeIcon is no longer needed since the Code Block is commented out.

Workflow ID: wflow_WYJ50kPNLytac7lJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 91639d2 in 5 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:2
  • Draft comment:
    Remove the unused CodeIcon import since the Code Block node is commented out.
  Cross2Icon,
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for CodeIcon is no longer needed since the Code Block node is commented out.

Workflow ID: wflow_4UrHBXUIzRD1MMSH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 9fe8dcb into main Oct 5, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/remove-codeblock-from-node-list branch October 5, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants