Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle search bar for custom selection #921

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 8, 2024

Important

Adds is_search_bar handling to prevent custom-selection logic for search bars in action handling.

  • Behavior:
    • Adds is_search_bar boolean field to JSON format in parse-input-or-select-context.j2.
    • Updates InputOrSelectContext in actions.py to include is_search_bar.
    • Modifies handle_input_text_action() in handler.py to exit custom selection mode if is_search_bar is true.
    • Updates input_or_auto_complete_input() and sequentially_select_from_dropdown() in handler.py to handle is_search_bar logic.

This description was created by Ellipsis for ce8d964. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ce8d964 in 17 seconds

More details
  • Looked at 104 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:1260
  • Draft comment:
    The check for is_search_bar is correctly integrated to prevent generating potential values for auto-completion when the element is a search bar. This ensures that the logic does not proceed unnecessarily for search bars.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces a new field is_search_bar in the JSON format and the InputOrSelectContext class. This field is used to determine if an element is a search bar and to handle it differently in the logic. The changes in the code are consistent with this new field, ensuring that custom selection logic is not triggered for search bars. The logic checks for is_search_bar in multiple places to exit early if the element is a search bar, which is the intended behavior. The changes are well-integrated into the existing code structure.
2. skyvern/webeye/actions/handler.py:1385
  • Draft comment:
    The check for is_search_bar is correctly integrated to exit custom selection mode for non-force search bars. This ensures that the logic does not proceed unnecessarily for search bars.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces a new field is_search_bar in the JSON format and the InputOrSelectContext class. This field is used to determine if an element is a search bar and to handle it differently in the logic. The changes in the code are consistent with this new field, ensuring that custom selection logic is not triggered for search bars. The logic checks for is_search_bar in multiple places to exit early if the element is a search bar, which is the intended behavior. The changes are well-integrated into the existing code structure.

Workflow ID: wflow_nlOlQ7uLbRddmUnp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 188f6eb into main Oct 8, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/handle-search-bar branch October 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant