Show terminate in the action type pills #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' Before:  After:  <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `terminate` action type to `ActionTypes` and `ReadableActionTypes` in `types.ts`. > > - **Action Types**: > - Add `terminate` to `ActionTypes` and `ReadableActionTypes` in `types.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 08bc92e35312de00b2e7fb85624b41fc3b423f96. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on baf5221 in 9 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/api/types.ts:201
- Draft comment:
Consider using consistent casing for action types. For example, 'complete' and 'wait' are lowercase, while others like 'InputText' are camel case. This inconsistency can lead to confusion. - Reason this comment was not posted:
Confidence changes required:50%
The PR correctly adds 'terminate' to both ActionTypes and ReadableActionTypes, as per the description. However, there is a minor inconsistency in the casing of action types.
Workflow ID: wflow_5A1BFgWCl08dQJqd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to baf5221 in 9 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/api/types.ts:201
- Draft comment:
Ensure consistent casing for action types. Consider using camelCase for all keys inActionTypesto match the existing pattern (e.g.,complete,wait). - Reason this comment was not posted:
Confidence changes required:50%
The PR correctly adds 'terminate' to both ActionTypes and ReadableActionTypes, as per the description. However, there is a minor inconsistency in the casing of action types.
Workflow ID: wflow_F0Cmdbp51yYkHBNb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ykeremy
deleted the
ykeremy/show-terminate-actions-in-action-history-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Important
Add
terminateaction type toActionTypesandReadableActionTypesintypes.ts.terminatetoActionTypesandReadableActionTypesintypes.ts.This description was created by
for baf5221. It will automatically update as commits are pushed.