Adjust task placeholders

[ykeremy]

Important

UI adjustments and placeholder text updates across multiple components in the Skyvern frontend to improve consistency and readability.

• UI Adjustments:
  • Update MultiSelect component in multi-select.tsx to reduce minimum height and adjust placeholder text size.
  • Adjust placeholder text and input sizes in CreateNewTaskForm.tsx and SavedTaskForm.tsx.
  • Update input field styles in DownloadNode.tsx, FileParserNode.tsx, SendEmailNode.tsx, TaskNode.tsx, TextPromptNode.tsx, and UploadNode.tsx to use smaller text size.
• Placeholder Text Updates:
  • Change placeholder text in CreateNewTaskForm.tsx and SavedTaskForm.tsx for clarity and consistency.
  • Use fieldPlaceholders in TaskNode.tsx for consistent placeholder text across fields.
• Schema and Error Handling:
  • Update taskFormTypes.ts to allow maxStepsOverride to be null and refine JSON validation for extractedInformationSchema and errorCodeMapping.

^{This description was created by for f88c605. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to f88c605 in 47 seconds

More details

• Looked at 623 lines of code in 11 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:185

• Draft comment:
  The fallback to MAX_STEPS_DEFAULT when maxStepsOverride is null is unnecessary since the default is already null. Consider removing the fallback to avoid confusion or unintended behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code changes in the PR involve updating placeholder text and input sizes across multiple components. The changes are consistent with the PR description, which aims to improve UI consistency and readability. However, there is a potential issue with the handling of maxStepsOverride in the SavedTaskForm.tsx file. The maxStepsOverride is set to null by default, but when sending the request, it uses a fallback to MAX_STEPS_DEFAULT if maxStepsOverride is null. This fallback is unnecessary since the default value is already null. This could lead to confusion or unintended behavior if the default is expected to be null.

2. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:121

• Draft comment:
  Ensure that the default value of maxStepsOverride is consistently handled across the application to avoid unexpected behavior. The logic here is correct, but consistency is key.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The PR updates placeholder text and input sizes across multiple components. In the CreateNewTaskForm.tsx, the maxStepsOverride is set to null by default, which aligns with the schema update. However, when sending the request, the code checks if maxStepsOverride is not null and not equal to MAX_STEPS_DEFAULT before including it in the headers. This logic is correct, but it's important to ensure that the default value of maxStepsOverride is consistently handled across the application to avoid any unexpected behavior.

Workflow ID: wflow_y8X0hc3rBksh8nJm

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on f88c605 in 52 seconds

More details

• Looked at 623 lines of code in 11 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:186

• Draft comment:
  Ensure consistency between the placeholder logic and the header value for x-max-steps-override. The placeholder suggests null if empty, but the header defaults to MAX_STEPS_DEFAULT.
• Reason this comment was not posted:
  Comment did not seem useful.

2. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:129

• Draft comment:
  Good consistency between the placeholder logic and the header value for x-max-steps-override. The placeholder suggests null if empty, and the header correctly uses formValues.maxStepsOverride.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR description mentions updating placeholder text for clarity and consistency. In the CreateNewTaskForm.tsx, the placeholder for the maxStepsOverride input field is updated to reflect the default value. However, in the mutation function, the header value for x-max-steps-override is set to formValues.maxStepsOverride, which is consistent with the placeholder logic that sets it to null if empty. This is correct and should be noted as a positive change.

Workflow ID: wflow_cBWuCHxApbcknZi7

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.