Rounded corners for code editor #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Apply `rounded-md` to CodeMirror components in `cloud/index.css` and `src/index.css` for rounded corners. > > - **Styles**: > - Apply `rounded-md` to `.cm-editor` and `.cm-gutters` in `cloud/index.css` and `src/index.css` for rounded corners in CodeMirror components. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for bd7ec71d1f13f0234903de147dd9fdf62ae884cb. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b87b467 in 8 seconds
More details
- Looked at
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/index.css:102
- Draft comment:
Ensurerounded-mdis defined in Tailwind config. It's a common utility, but double-check. - Reason this comment was not posted:
Confidence changes required:50%
The use of@applyforrounded-mdis correct, but it's important to ensure that therounded-mdutility is defined in the Tailwind configuration. This is a common utility, so it's likely defined, but it's worth checking.
Workflow ID: wflow_fiUnyRHYM8kySFzY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b87b467 in 10 seconds
More details
- Looked at
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/index.css:102
- Draft comment:
Ensurerounded-mdis defined in your Tailwind configuration. This utility should be available for@applyto work correctly. - Reason this comment was not posted:
Confidence changes required:50%
The use of@applyforrounded-mdis correct, but it's important to ensure that therounded-mdutility is defined in the Tailwind configuration. This is a common oversight when using Tailwind CSS.
Workflow ID: wflow_WqxvUPkD8Srqe3Yn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
rounded-mdto CodeMirror components insrc/index.cssfor rounded corners.rounded-mdto.cm-editorand.cm-guttersinsrc/index.cssfor rounded corners in CodeMirror components.This description was created by
for b87b467. It will automatically update as commits are pushed.