Fix action list live button appearance issue when there are no actions #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `className="w-full"` to `ScrollArea` in `ScrollableActionList.tsx` to fix layout issue when no actions are present. > > - **UI Fix**: > - Add `className="w-full"` to `ScrollArea` in `ScrollableActionList.tsx` to ensure full width rendering when no actions are present. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b9e8fec59429c43b4daa94db4bfb22d8856c8745. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 89fdfe6 in 14 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/detail/ScrollableActionList.tsx:159
- Draft comment:
The addition ofclassName="w-full"toScrollAreais correct and addresses the layout issue as intended. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly addsclassName="w-full"toScrollAreato fix the layout issue. No further changes are needed for this line.
Workflow ID: wflow_VpO9e3zJtvbvRf4j
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 89fdfe6 in 12 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_s9d1KWyKPOqh7tXl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
className="w-full"toScrollAreainScrollableActionList.tsxto fix layout issue when no actions are present.className="w-full"toScrollAreainScrollableActionList.tsxto ensure full width rendering when no actions are present.This description was created by
for 89fdfe6. It will automatically update as commits are pushed.