gpt4o mini pricing for massive #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Update `model_name` for `MASSIVE_AZURE_OPENAI_GPT4O_MINI` and add `model_info` to `LiteLLMParams` and `LLMConfig`. > > - **Behavior**: > - Update `model_name` for `MASSIVE_AZURE_OPENAI_GPT4O_MINI` in `cloud/__init__.py` to `azure/global-standard/gpt-4o-mini`. > - **Models**: > - Add `model_info` to `LiteLLMParams` in `models.py`. > - **Config**: > - Add `model_info` to `LLMConfig` in `config_registry.py`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b893722187c451922ca6936c0419b7a54e4093f9. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 20157f4 in 10 seconds
More details
- Looked at
38lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/models.py:11
- Draft comment:
ChangingLiteLLMParamsfromTypedDicttodataclassis not backward compatible. Ensure this change is reflected throughout the codebase and does not break existing functionality. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_a24TD2cFfv1k7Wrv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 20157f4 in 16 seconds
More details
- Looked at
38lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/models.py:15
- Draft comment:
TheLLMConfigclass is missing themodel_infofield as described in the PR. Consider adding it to align with the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_S9glKei1ET8drZJA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
model_nameforMASSIVE_AZURE_OPENAI_GPT4O_MINIand addmodel_infotoLiteLLMParamsandLLMConfig.model_nameforMASSIVE_AZURE_OPENAI_GPT4O_MINIinconfig_registry.pytoazure/global-standard/gpt-4o-mini.model_infotoLiteLLMParamsinmodels.py.model_infotoLLMConfiginconfig_registry.py.This description was created by
for 20157f4. It will automatically update as commits are pushed.