Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text in task form #962

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Change text in task form #962

merged 1 commit into from
Oct 11, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 11, 2024

Important

Update button text to 'Run' and add 'PlayIcon' in CreateNewTaskForm.tsx and SavedTaskForm.tsx.

  • UI Changes:
    • In CreateNewTaskForm.tsx, changed button text from Create to Run and added PlayIcon next to the text.
    • In SavedTaskForm.tsx, changed button text from Run Task to Run and added PlayIcon next to the text.

This description was created by Ellipsis for 31a9b46. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Change button text to 'Run' and add 'PlayIcon' in `CreateNewTaskForm.tsx` and `SavedTaskForm.tsx`.
>
>   - **UI Changes**:
>     - In `CreateNewTaskForm.tsx`, changed button text from `Create` to `Run` and added `PlayIcon` next to the text.
>     - In `SavedTaskForm.tsx`, changed button text from `Run Task` to `Run` and added `PlayIcon` next to the text.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 1956df9ee094c0e79fdd63fa53b0ef810718a766. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 31a9b46 in 10 seconds

More details
  • Looked at 52 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:22
  • Draft comment:
    PlayIcon is imported but not used. Consider removing it to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import statement for PlayIcon was added, but the PlayIcon is not used in the CreateNewTaskForm.tsx file. This is unnecessary and should be removed.

Workflow ID: wflow_ZjEllM34XupwQiMG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 31a9b46 in 14 seconds

More details
  • Looked at 52 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:608
  • Draft comment:
    Consider using a ternary operator for consistency with the SavedTaskForm.tsx file.
{mutation.isPending ? (
  <ReloadIcon className="mr-2 h-4 w-4 animate-spin" />
) : (
  <PlayIcon className="mr-2 h-4 w-4" />
)}
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description indicates a change in button text and icon, which is correctly implemented. However, the code can be improved for readability and maintainability.
2. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:799
  • Draft comment:
    Consider using a consistent approach for conditional rendering as in CreateNewTaskForm.tsx.
{createAndSaveTaskMutation.isPending ? (
  <ReloadIcon className="mr-2 h-4 w-4 animate-spin" />
) : (
  <PlayIcon className="mr-2 h-4 w-4" />
)}
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description indicates a change in button text and icon, which is correctly implemented. However, the code can be improved for readability and maintainability.

Workflow ID: wflow_BO8w2QCTr0E7QuHF


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 10353ce into main Oct 11, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/task-form-button-text branch October 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants