Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json: move nikic/php-parser into dev dependencies #60

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

voku
Copy link
Contributor

@voku voku commented Aug 1, 2024

ref.: #59

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (3cafd8c) to head (c8fa4ac).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     97.89%   97.89%           
  Complexity      149      149           
=========================================
  Files            15       15           
  Lines           332      332           
=========================================
  Hits            325      325           
  Misses            7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@voku
Copy link
Contributor Author

voku commented Aug 1, 2024

I think the composer-require-checker check --config-file=$(realpath composer-require-checker.json) command is not working here, because it's a extension for a phar file and that can't be checked.

@Slamdunk
Copy link
Owner

Slamdunk commented Aug 1, 2024

Then please add it to the ignore list

@Slamdunk Slamdunk merged commit 389ac3a into Slamdunk:master Aug 1, 2024
7 checks passed
@Slamdunk
Copy link
Owner

Slamdunk commented Aug 1, 2024

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants