Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puts _params in Push Notification #4

Merged

Conversation

stefanahman
Copy link
Contributor

Removes output when calling as_json method.

Why? Output gets printed in test suite:

> rspec spec/models/push_notification_spec.rb

Randomized with seed 26855

PushNotification
  #send_notification
    calls SendPushNotifications
  #to_expo
{:title=>"Title", :body=>"Message", :sound=>"bam"}
    gets converted to Expo push notification

@SleeplessByte
Copy link
Owner

Ah haha. That's not intended :)

Do you need a release on rubygems or will you reference this?

@SleeplessByte SleeplessByte merged commit 11d5dcf into SleeplessByte:main Mar 17, 2023
@stefanahman stefanahman deleted the remove-notification-as-json-puts branch March 17, 2023 17:15
@stefanahman
Copy link
Contributor Author

Ah haha. That's not intended :)

Do you need a release on rubygems or will you reference this?

A batch release would be preferred if there's no other planned anytime soon 🙏🏻

@SleeplessByte
Copy link
Owner

Ping me if you don't have it by next week please!

@stefanahman
Copy link
Contributor Author

@SleeplessByte ping!

@SleeplessByte
Copy link
Owner

https://rubygems.org/gems/expo-server-sdk/versions/0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants