Fixed compile errors present with latest build tools

SlideRuleEarth · Jun 12, 2024 · 284ebf3 · 284ebf3
1 parent 7985207
commit 284ebf3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/packages/arrow/ArrowCommon.cpp b/packages/arrow/ArrowCommon.cpp
@@ -250,7 +250,7 @@ bool send2S3 (const char* fileName, const char* s3dst, const char* outputPath,
 /*----------------------------------------------------------------------------
  * send2Client
  *----------------------------------------------------------------------------*/
-bool send2Client (const char* fileName, const char* outPath, ArrowParms* parms, Publisher* outQ)
+bool send2Client (const char* fileName, const char* outPath, const ArrowParms* parms, Publisher* outQ)
 {
     bool status = true;
 

diff --git a/packages/arrow/ArrowCommon.h b/packages/arrow/ArrowCommon.h
@@ -67,8 +67,8 @@ namespace ArrowCommon
                             uint32_t traceId, ArrowParms* parms, Publisher* outQ);
     bool        send2S3    (const char* fileName, const char* s3dst, const char* outputPath,
                             ArrowParms* parms, Publisher* outQ);
-    bool        send2Client(const char* fileName, const char* outPath, 
-                            ArrowParms* parms, Publisher* outQ);
+    bool        send2Client(const char* fileName, const char* outPath,
+                            const ArrowParms* parms, Publisher* outQ);
 
     const char* getOutputPath(ArrowParms* parms);
     const char* getUniqueFileName(const char* id = NULL);

diff --git a/packages/h5/H5Element.h b/packages/h5/H5Element.h
@@ -119,12 +119,12 @@ bool H5Element<T>::join(int timeout, bool throw_exception)
             status = true;
             if(h5f->info.datatype == RecordObject::STRING)
             {
-                /* 
+                /*
                  * T is here assumed to be `const char*` or something analogous.
-                 * Casting the raw data blindly to a C-like string is provided as a 
-                 * convenience for working directly with HDF5 data in C/C++ but is 
-                 * admittedly very unsafe. It is the responsibility of the calling code 
-                 * to know that the element being read is a string. 
+                 * Casting the raw data blindly to a C-like string is provided as a
+                 * convenience for working directly with HDF5 data in C/C++ but is
+                 * admittedly very unsafe. It is the responsibility of the calling code
+                 * to know that the element being read is a string.
                  */
                 setDataIfPointer(&value, h5f->info.data);
             }
@@ -138,7 +138,7 @@ bool H5Element<T>::join(int timeout, bool throw_exception)
                 * for knowing what the data being read out of the h5 file is and
                 * providing the correct type to the template.
                 */
-                T* value_ptr = reinterpret_cast<T*>(h5f->info.data);
+                const T* value_ptr = reinterpret_cast<T*>(h5f->info.data);
                 value = *value_ptr;
             }
             size = h5f->info.datasize;

diff --git a/project-config.cmake b/project-config.cmake
@@ -125,6 +125,7 @@ if(CMAKE_BUILD_TYPE MATCHES "Debug")
         "--suppress=memsetClassFloat:*/MathLib.cpp"                     # line: 80, need memset here for performance
         "--suppress=unreadVariable:*/TimeLib.cpp"                       # line: 471, terminating '\0' detected as 'unused' but it is used/needed
         "--suppress=invalidPointerCast:*/H5Array.h"                     # line: 166, documented in code
+        "--suppress=invalidPointerCast:*/H5Element.h"                   # line: 141, documented in code
         "--suppress=copyCtorPointerCopying:*/MsgQ.cpp"                  # line: 120, shallow copy which is fine in code
         "--error-exitcode=1"