-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about atl06p processing params for multiple outputs #448
Comments
As an update, after playing around with the SR demo client, I refined my point selection to: parms_dict = {
"high_confidence": {
"cnf": 4,
"srt": -1,
},
"ground": {
"cnf": 0,
"srt": -1,
"atl08_class": "atl08_ground",
},
"canopy": {
"cnf": 0,
"srt": -1,
"atl08_class": "atl08_canopy",
},
"top_of_canopy": {
"cnf": 0,
"srt": -1,
"atl08_class": "atl08_top_of_canopy",
},
} The only difference here being the |
Hi Ben, what you are doing looks right to me. Here are my comments:
|
Great! I kind of interpreted that from my reading online but just wanted to be sure I understood
No issues with this from my work thus far!
Yes, I was not that convinced by my "high_confidence" parameters, realizing that these are not necessarily "ground" but just any "surface" returns, which might mix land surface types (veg, snow + ice, etc.), and think I will likely drop that in favor of the three atl08-based requests, which better target and separate the points into clear classes for further analysis. Thanks for confirming my thoughts there. |
For a discussion of this, see: SlideRuleEarth/sliderule#448. The main point is that "high_confidence" points are not necessarily a given surface type. Instead, we want to focus on just getting the ground, canopy, and top of canopy, which we already do. This commit removes all traces of "high_confidence" points from the codebase. In addition, this commit speeds up the altimetry tests by skipping the actual external retrieval call. This means the `request_atl06sr_multi_processing` function is not tested, but that is mostly a wrapper for sliderule anyway. Tests are passing locally. Failing tests on CI may have to do with the CI setup on GitHub.
This commit removes all traces of "high_confidence" points from the codebase. For a discussion of this, see: SlideRuleEarth/sliderule#448. The main point is that "high_confidence" points are not necessarily a given surface type. Instead, we want to focus on just getting the ground, canopy, and top of canopy, which we already do. In addition, this commit speeds up the altimetry tests by skipping the actual external retrieval call. This means the `request_atl06sr_multi_processing` function is not tested, but that is mostly a wrapper for sliderule anyway. Also, I fixed CI tests here, by dropping use of mamba in favor of conda, which seems to have fixed things.
I have a method in a package I'm building that looks like this:
Ultimately, what I'm trying to do here, is gather four processing levels of ATL06: "high_confidence", "ground", "canopy", and "top_of_canopy". The method also accepts the important fitting parameters
res
,len
,cnt
, etc. that are applied to all four processing levels, should the user want to tweak those (but they default to the ATL06 defaults).I built up the four processing levels, e.g.
By carefully reading the SlideRule ICESat-2 docs page, and concluding that I needed a combination of
srt
,cnf
, andatl08_class
parameters as specified in myparms_dict
variable.However, I'm still not 100% sure these are the four combinations of processing parameters that will return exactly what I want (high confidence ground; and ATL08-classified ground, canopy, and top of canopy). In particular, I'm not sure I want to use that
atl08_class
parameter for this use case.For instance, I know there are also the PhoREAL and the yapc parameters, which might also get at what I'm after with this multi-processing.
Am I on the right track with my parameter selection above? cc @dshean
Thanks!
The text was updated successfully, but these errors were encountered: