Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include java in all product releases #1376

Closed
wimjongman opened this issue Aug 30, 2021 · 11 comments
Closed

Include java in all product releases #1376

wimjongman opened this issue Aug 30, 2021 · 11 comments
Labels
4.4.1 importance: improvement request OS: all status: fixed in 4.4.1
Milestone
4.4.1

Comments

@wimjongman
Copy link
Member

When people are using 4.3.3 product, the jre is not updated when "Check for updates" is performed. The product is updated and restarted, but it still runs the old JRE which is version 8.

After closing and starting Sloeber, a message is shown that the jre is outdated. The jre directory must be renamed (e.g. to jrexxx) or deleted. Then Sloeber will pickup the installed jre.

This is not a pleasant experience and is even more problematic when people are not into "installing java" and just want to update Sloeber and run.

One solution is to include the justj java environment. This is an embedded jvm and Eclipse also ships with it.
@wimjongman wimjongman mentioned this issue Aug 30, 2021
Closed
wimjongman added a commit that referenced this issue Aug 30, 2021
@wimjongman
Old Sloeber product cannot be updated #1376
c175380 
* Include an embedded JRE in the product
* Update version numbers to 4.4.1
wimjongman added a commit that referenced this issue Aug 30, 2021
@wimjongman
Old Sloeber product cannot be updated #1376
dc56003 
* Include an embedded JRE in the product
* Update version numbers to 4.4.1
* Fixed all features to be root features
* Updated the eclipse license to v2.0
* Fixed the malformed representation of the license
* Added more memory to IDE
* Increased startup memory
@wimjongman wimjongman added this to the 4.4.1 milestone Aug 30, 2021
@jantje
Copy link
Member

jantje commented Aug 30, 2021

This would be a great thing as I have been struggling in getting jre's into the product and I am only confident enough to do it for windows.
If this would add a jre to all supported osses that would be great :-)

wimjongman added a commit that referenced this issue Aug 30, 2021
@wimjongman
Old Sloeber product cannot be updated #1376
3991622 
* Include an embedded JRE in the product
* Update version numbers to 4.4.1
* Fixed all features to be root features
* Updated the eclipse license to v2.0
* Fixed the malformed representation of the license
* Added more memory to IDE
* Increased startup memory
* Update splash - Added version, removed Beryllium
@wimjongman
Copy link
Member Author

I assume that you are adding the jre library to the build in a post step, correct?

@jantje
Copy link
Member

jantje commented Aug 30, 2021

I assume that you are adding the jre library to the build in a post step, correct?

yes
On the jenkings build

I tried the new code here; Did a maven build and unzipped "sloeber-ide-sloeber_release-win32.win32.x86_64"
Started it and saw it was using my system installed java
This was not what I expected :-(

@wimjongman
Copy link
Member Author

Started it and saw it was using my system installed java

Are you on the correct branch?

@jantje
Copy link
Member

jantje commented Aug 30, 2021

I'm on master (all the time ;-) )

@wimjongman
Copy link
Member Author

I'm on master (all the time ;-) )

Yeah, that is the wrong branch.

@jantje
Copy link
Member

jantje commented Aug 31, 2021

Yeah, that is the wrong branch.

I'm proving my incompetence again 🥇

@jantje
Copy link
Member

jantje commented Aug 31, 2021

Woot !!! 🎆
Seems this works (on windows)
Need to test this on linux

@jantje
Copy link
Member

jantje commented Sep 8, 2021

I tested this on windows.
Is there any reason not to merge this into master?

@wimjongman
Copy link
Member Author

Please merge if you are happy with it.

@jantje
Copy link
Member

jantje commented Sep 8, 2021

I'm happy :-)

@jantje jantje changed the title Old Sloeber product cannot be updated Include java in all product releases Sep 8, 2021
@jantje jantje closed this as completed Sep 8, 2021
@jantje jantje mentioned this issue Sep 13, 2021
Closed
@jantje jantje mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.4.1 importance: improvement request OS: all status: fixed in 4.4.1
Projects
None yet
Milestone
4.4.1
Development

No branches or pull requests
2 participants
@wimjongman @jantje