Skip to content

Commit

Permalink
refactors to individual tests modules
Browse files Browse the repository at this point in the history
  • Loading branch information
WolfgangFahl committed Jul 16, 2021
1 parent 7b4ea76 commit 34ec5e2
Show file tree
Hide file tree
Showing 10 changed files with 198 additions and 158 deletions.
9 changes: 5 additions & 4 deletions migration/openresearch/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def getSamples(self):
return samplesLOD

@classmethod
def getSampleWikiSon(cls, mode='legacy'):
def getSampleWikiTextList(cls, mode='legacy'):
'''
Returns a sample of Event Series in wikison format
Args:
Expand All @@ -390,7 +390,6 @@ def getSampleWikiSon(cls, mode='legacy'):
samplesWikiSon = "..."

return samplesWikiSon



def __str__(self):
Expand Down Expand Up @@ -484,14 +483,15 @@ def getSamples(cls):
{
'acronym': "IDC 2009",
'title': "The 8th International Conference on Interaction Design and Children",
'pageTitle': 'IDC 2009'
'pageTitle': 'IDC 2009',
'ordinal': 8
}

]
return samplesLOD

@classmethod
def getSampleWikiSon(cls,mode='legacy'):
def getSampleWikiTextList(cls,mode='legacy'):
if mode=='legacy':
samplesWikiSon=["""{{Event
|Acronym=ICSME 2020
Expand All @@ -518,6 +518,7 @@ def getSampleWikiSon(cls,mode='legacy'):
}}''',
'''36th IEEE International Conference on Software Maintenance and Evolution (ICSME)'''""","""{{Event
|Acronym=AISB 2009
|Ordinal=36
|Title=AISB Symposium: New Frontiers in Human-Robot Interaction
|Type=Conference
|Field=Uncategorized
Expand Down
10 changes: 3 additions & 7 deletions migration/ormigrate/issue152_acceptancerate.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
@author: wf
'''
import re
from ormigrate.fixer import PageFixerManager,PageFixer
from ormigrate.rating import Rating,RatingType
from ormigrate.fixer import PageFixer


class AcceptanceRateFixer(PageFixer):

Expand Down Expand Up @@ -71,10 +70,7 @@ def getRating(self,eventRecord):
return painrating


if __name__ == "__main__":
fixer=AcceptanceRateFixer()
fixer.debug=True
# fixer.checkAllFiles(fixer.check)
# print (fixer.result())
if __name__ == '__main__':
PageFixerManager.runCmdLine([AcceptanceRateFixer])


6 changes: 1 addition & 5 deletions migration/ormigrate/issue71_date.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,4 @@ def getRating(self,eventRecord):
return painrating

if __name__ == "__main__":
fixer = DateFixer()
fixer.debug = True
# fixer.checkAllFiles(fixer.getFixedDate, 'deadline')
fixer.fixAllFiles(fixer.getFixedDateWikiFile, "Date", 'date')
fixer.fixAllFiles(fixer.getFixedDateWikiFile, "Deadline", 'deadline')
PageFixerManager.runCmdLine([DateFixer])
137 changes: 0 additions & 137 deletions migration/tests/testDataFixes.py

This file was deleted.

56 changes: 56 additions & 0 deletions migration/tests/testIssue152_acceptanceRate.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
'''
Created on 2021-07-16
@author: wf
'''
import unittest


class TestIssue153AcceptanceRate(unittest.TestCase):


def setUp(self):
pass


def tearDown(self):
pass


def testIssue152(self):
'''
test for fixing Acceptance Rate Not calculated
https://github.com/SmartDataAnalytics/OpenResearch/issues/152
'''
eventRecords= [{'submittedPapers':'test', 'acceptedPapers':'test'},
{'submittedPapers': None, 'acceptedPapers':None},
{'submittedPapers':'test', 'acceptedPapers':None},
{'submittedPapers':None, 'acceptedPapers':'test'}]
painRatings=[]
fixer=self.getAcceptanceRateFixer()
for event in eventRecords:
painRating =fixer.getRating(event)
self.assertIsNotNone(painRating)
painRatings.append(painRating.pain)
self.assertEqual(painRatings,[1,3,5,7])
pages=fixer.getAllPages()
if self.debug:
print("Number of pages: ", len(pages))
expectedPages=0 if hf.inPublicCI() else 8000
self.assertTrue(len(pages)>=expectedPages)
events=list(fixer.getAllPageTitles4Topic("Event"))
expectedEvents=0 if hf.inPublicCI() else 5500
if self.debug:
print("Number of events: ", len(events))
self.assertTrue(len(events)>=expectedEvents)
fixer.checkAllFiles(fixer.check)
if self.debug:
print(fixer.result())
print(expectedEvents)
self.assertTrue(fixer.nosub>=0 if hf.inPublicCI() else 50)
self.assertTrue(fixer.nosub>=0 if hf.inPublicCI() else 50)


if __name__ == "__main__":
#import sys;sys.argv = ['', 'Test.testName']
unittest.main()
10 changes: 6 additions & 4 deletions migration/tests/testIssue155__OOAccess.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,11 @@ def testEventSeries(self):
eventSeriesList.fromLoD(lod)
self.assertTrue(len(eventSeriesList.getList())>0)
for eventSeries in eventSeriesList.getList():
self.assertTrue(isinstance(eventSeries,EventSeries))
self.assertTrue(eventSeries.acronym is not None)
if self.debug:
print(eventSeries)
self.assertTrue(isinstance(eventSeries,EventSeries))
self.assertTrue(eventSeries.acronym is not None)


def testEvent(self):
'''
Expand All @@ -51,11 +52,12 @@ def testEvent(self):
eventList.fromLoD(lod)
self.assertTrue(len(eventList.getList())>0)
for event in eventList.getList():
if self.debug:
print(event)
self.assertTrue(isinstance(event,Event))
self.assertTrue(event.acronym is not None)
self.assertTrue(event.ordinal is not None)
if self.debug:
print(event)



def getSQLDB(self,path=None):
Expand Down
45 changes: 45 additions & 0 deletions migration/tests/testIssue163_series.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
'''
Created on 2021-07-16
@author: wf
'''
import unittest


class TestIssue163(unittest.TestCase):
'''
'''

def setUp(self):
pass


def tearDown(self):
pass


def testIssue163(self):
'''
Series Fixer
'''
#self.debug=True
eventRecords = [{'inEventSeries': '3DUI', 'has Bibliography': 'test'},
{'inEventSeries': ['test','test2'], 'endDate': '20 Feb, 2020'},
{'Ordinal': 2},
]
expectedPainRatings=[1, 9, 7]
fixer=self.getSeriesFixer()
painRatings=[]
for eventRecord in eventRecords:
painRating=fixer.getRating(eventRecord)
painRatings.append(painRating.pain)
self.assertEqual(expectedPainRatings, painRatings)
askExtra="" if hf.inPublicCI() else "[[Creation date::>2018]][[Creation date::<2020]]"
count=fixer.checkAll(askExtra)
# TODO: we do not test the count here - later we want it to be zero
# TODO: Records obtained with fromWiki already filter the list


if __name__ == "__main__":
#import sys;sys.argv = ['', 'Test.testName']
unittest.main()
Loading

0 comments on commit 34ec5e2

Please sign in to comment.