Fixed Popen erroneous call and added st #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've just started using eve-ng for a network class at uni, and I've run into an issue with the client integration. Basically, the telnet opening would cause the program to exit with a code 1.
I've been able to pin-point that down to the
Popen
call, it seems like it expects every argument to be an item of the list instead of having one with spaces (see: https://docs.python.org/3/library/subprocess.html#popen-constructor). I am not a Python specialist, but simply splitting thecommand
list if its length equals to one fixed it for me.I've also added
st
in the term finder since it was not here.Please tell me if I have accidentally broken something by fixing the issue that way (I've taken an extra security step by splitting only if the length equals 1).
Kind Regards,
Noah