Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Popen erroneous call and added st #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noahboegli
Copy link

Hi!

I've just started using eve-ng for a network class at uni, and I've run into an issue with the client integration. Basically, the telnet opening would cause the program to exit with a code 1.

I've been able to pin-point that down to the Popen call, it seems like it expects every argument to be an item of the list instead of having one with spaces (see: https://docs.python.org/3/library/subprocess.html#popen-constructor). I am not a Python specialist, but simply splitting the command list if its length equals to one fixed it for me.

I've also added st in the term finder since it was not here.

Please tell me if I have accidentally broken something by fixing the issue that way (I've taken an extra security step by splitting only if the length equals 1).

Kind Regards,
Noah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant