Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ticket delete method and various other improvements #808

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

micwallace
Copy link
Collaborator

  • Add ticketStorage method to delete token from collection by providing tokenId or DecodedToken object.
  • Change ticket storage to a public readonly property of LocalOutlet.
  • Define the interface for EventSenderTokensSelected.
  • Remove redundant EventSenderTokens interface.

- Add ticketStorage method to delete token from collection
  by providing tokenId or DecodedToken object.
- Change ticket storage to a public readonly property of LocalOutlet.
- Define the interface for EventSenderTokensSelected.
- Remove redundant EventSenderTokens interface.
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
37.56% (-0.13% 🔻)
1365/3634
🔴 Branches
24.65% (-0.09% 🔻)
391/1586
🔴 Functions
38.49% (-0.16% 🔻)
184/478
🔴 Lines
37.98% (-0.09% 🔻)
1163/3062
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 client/index.ts 44.93%
42.02% (-0.24% 🔻)
55.13% 46.01%
🔴
... / ticketStorage.ts
23.25% (-1.28% 🔻)
3.64% (-0.1% 🔻)
22.73% (-2.27% 🔻)
25.42% (-1.08% 🔻)

Test suite run success

84 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from e7cc143

@futantan
Copy link

CleanShot 2023-08-25 at 16 10 41@2x

hi @micwallace the first params of deleteTicketByDecodedTokenOrId is collectionId, but this only work if I pass the index of that config in the issuers, can you help to fix that>

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@futantan futantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktaras nicktaras merged commit 689748b into staging Aug 27, 2023
5 checks passed
@nicktaras
Copy link
Collaborator

@futantan, @micwallace Merged this change from our catch up last week.

I'll run a smoke test inside staging across on/off chain versions and can do the release today.

@micwallace micwallace deleted the feat/outlet-ticket-remove branch September 18, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants