Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1213 Fulltext collection for category RSS #1215

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fixes #1213 Fulltext collection for category RSS #1215

merged 1 commit into from
Dec 5, 2018

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Dec 3, 2018

feed dataprovider

@rbayet rbayet requested a review from romainruaud December 3, 2018 18:23
@rbayet
Copy link
Collaborator Author

rbayet commented Dec 3, 2018

DONE :

  • fatal error fixed by injecting correct collection factory

TODO :

  • check that changing the collection type does not alter results

@rbayet rbayet mentioned this pull request Dec 4, 2018
Merged
@romainruaud
Copy link
Collaborator

Is it ready to merge ? I see a todo.

@rbayet
Copy link
Collaborator Author

rbayet commented Dec 4, 2018

@romainruaud it's not ready to merge

@rbayet
Copy link
Collaborator Author

rbayet commented Dec 4, 2018

DONE :

* fatal error fixed by injecting correct collection factory

TODO :

* check that changing the collection type does not alter results

The fix is not valid : while the fatal error is avoided, all category RSS feeds contain the same products, certainly because the (category) context is missing.

@romainruaud
Copy link
Collaborator

Since this one is a low priority, if it's not ready to be merged today, it will be discarded and postponed to next minor versions.

@rbayet rbayet force-pushed the fix_1213_category_rss_feed branch 2 times, most recently from b5c97f4 to deb9d3f Compare December 5, 2018 10:50
@rbayet
Copy link
Collaborator Author

rbayet commented Dec 5, 2018

@romainruaud Got it working.

@rbayet rbayet force-pushed the fix_1213_category_rss_feed branch from deb9d3f to 2f9892f Compare December 5, 2018 10:59
@rbayet rbayet changed the title WIP Fixes #1213 Fulltext collection for category RSS Fixes #1213 Fulltext collection for category RSS Dec 5, 2018
@romainruaud romainruaud merged commit df1cb18 into Smile-SA:2.6.x Dec 5, 2018
@rbayet rbayet deleted the fix_1213_category_rss_feed branch December 11, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud Awaiting requested review from romainruaud

Assignees

@romainruaud romainruaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbayet @romainruaud