Ensure catalog requests have the proper type. #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes #392
When using previously
Magento\CatalogSearch\Model\Layer\Search\ItemCollectionProviderwe were using aMagento\CatalogSearch\Model\ResourceModel\Fulltext\SearchCollectionFactorywhich was using aMagento\CatalogSearch\Model\ResourceModel\Fulltext\SearchCollection.This one always had the searchRequestName set to "quick_search_container", even when browsing the catalog.
I replaced it by direct usage of ElasticSuite Fulltext collection, allowing us to have the default value for catalog navigation which is
catalog_view_container