Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Faker formatter earlier #108

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Resolve Faker formatter earlier #108

merged 1 commit into from
Feb 20, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 19, 2024

PR Checklist

Please check if your pull request fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

as discussed in #106 with this PR we resolve Faker formatters earliser, so possible invalid formatters will be reported before the dump is started

Issue Number: #106

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@staabm staabm marked this pull request as ready for review February 19, 2024 17:30
@guvra guvra merged commit e14618b into Smile-SA:main Feb 20, 2024
3 checks passed
@staabm staabm deleted the early-err branch February 20, 2024 10:39
@staabm
Copy link
Contributor Author

staabm commented Feb 20, 2024

Thank you @guvra

@guvra guvra added the feature New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants