Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict types in schema.json #129

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Use strict types in schema.json #129

merged 1 commit into from
Jun 4, 2024

Conversation

guvra
Copy link
Collaborator

@guvra guvra commented Mar 26, 2024

Currently, the schema file that is used to validate the config file is very permissive.

For example, most parameters that are supposed to be strings accept integer values:

tables_whitelist:
    - 0 # this is considered valid

This PR changes all string parameters to accept only string values.

This is a breaking change, this feature will be released in 5.0.0.

@guvra guvra added this to the 5.0.0 milestone Mar 26, 2024
@guvra guvra force-pushed the feat-strict-schema branch 3 times, most recently from 5bb2f03 to 41df5dd Compare March 26, 2024 16:19
@guvra guvra force-pushed the feat-strict-schema branch from 41df5dd to 686489c Compare April 9, 2024 09:47
@guvra guvra force-pushed the feat-strict-schema branch from 686489c to 3b44e53 Compare June 4, 2024 08:13
@guvra guvra force-pushed the feat-strict-schema branch from 3b44e53 to af0b8df Compare June 4, 2024 08:14
@guvra guvra merged commit 82d66f6 into main Jun 4, 2024
3 checks passed
@guvra guvra deleted the feat-strict-schema branch June 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant