Storage improvements #2263
Merged
Storage improvements #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
reviewed
Mar 14, 2021
| @@ -22,6 +22,11 @@ String SpiFlash::getName() const | |||
| return FS_SPIFLASH; | |||
| } | |||
|
|
|||
| uint32_t SpiFlash::getID() const | |||
There was a problem hiding this comment.
Please rename the method to getId()
| @@ -22,6 +22,11 @@ String SpiFlash::getName() const | |||
| return FS_SPIFLASH; | |||
| } | |||
|
|
|||
| uint32_t SpiFlash::getID() const | |||
There was a problem hiding this comment.
Please rename the method to getId()
| * @brief Obtain device ID | ||
| * @retval uint32_t typically flash chip ID | ||
| */ | ||
| virtual uint32_t getID() const |
Reduce default esp32 app partition size, bit big QIO mode doesn't always work, remove it List storage devices, with ID
Using GNU make / mingw conventions
mikee47
force-pushed
the
feature/storage-improvements
branch
from
c40b6d0 to
b5c8121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic_rBoot
Add
Storage::Device::getID()methodAdd
spi_flash_get_id()implementation for ESP32Update Basic_Storage sample
Add
flashconfigtarget for HostFix inconsistent HWCONFIG path separation in Windows
Remove unused header
Fix use of deprecated functions