Feature/kms optimizations #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
feature/kms_optimizations
branch
2 times, most recently
from
c3d6824 to
168f7b2
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 24.00% 24.01% +0.01%
==========================================
Files 140 140
Lines 21583 21583
==========================================
+ Hits 5180 5183 +3
+ Misses 16403 16400 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmeissl
force-pushed
the
feature/kms_optimizations
branch
from
168f7b2 to
164d155
Compare
|
FYI this fixes a direct scanout bug when clear color is black |
|
I'd like to see this move along due to the bug fix. Anything I can do to help? |
|
Sorry for taking so long, I continued to work on this and hope we can get it merged in the next couple of days. |
cmeissl
force-pushed
the
feature/kms_optimizations
branch
4 times, most recently
from
18a6d24 to
694be18
Compare
Drakulix
approved these changes
Sep 3, 2023
cmeissl
force-pushed
the
feature/kms_optimizations
branch
from
694be18 to
fb467e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to reduce the amount of atomic tests we issue.
A quick profile already shows that this can greatly improve the time we spend in
render_frame:Draft because this needs more in depth testing.