Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm leasing #1132

Merged
merged 2 commits into from
Sep 25, 2023
Merged

drm leasing #1132

merged 2 commits into from
Sep 25, 2023

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Sep 13, 2023

TODO:

  • Do a drm-rs release
  • Make the handler withdraw/re-annouce successfully leased/released connectors internally, so downstream doesn't need to track and call withdraw_connector and add_connector respectively.
  • Add suspend/resume to temporarily revoke all leases/advertised connectors while session is inactive / master was lost
  • Implement in anvil
  • Actually test the damn thing

@Drakulix Drakulix force-pushed the feature/drm_lease branch 2 times, most recently from d4c5013 to 7b45244 Compare September 21, 2023 21:03
@Drakulix Drakulix marked this pull request as ready for review September 21, 2023 21:03
@Drakulix Drakulix requested review from cmeissl and i509VCB September 21, 2023 21:04
@Drakulix
Copy link
Member Author

Ready for review, just waiting for a drm-rs release. I tested this extensively and tried to cleanup the code as much as possible.

@Drakulix Drakulix force-pushed the feature/drm_lease branch 4 times, most recently from bcba43b to 4e6c1a9 Compare September 23, 2023 20:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (93bc729) 22.86% compared to head (822fd66) 22.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   22.86%   22.85%   -0.02%     
==========================================
  Files         144      144              
  Lines       23386    23386              
==========================================
- Hits         5348     5345       -3     
- Misses      18038    18041       +3     
Flag Coverage Δ
wlcs-buffer 19.75% <ø> (ø)
wlcs-core 19.41% <ø> (ø)
wlcs-output 8.21% <ø> (ø)
wlcs-pointer-input 21.64% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drakulix Drakulix requested a review from cmeissl September 23, 2023 21:37
Copy link
Collaborator

@cmeissl cmeissl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just a theoretical question about the use in anvil

@Drakulix Drakulix merged commit 613345a into master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants