Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wayland] Implement XdgForeign #1342

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

PolyMeilex
Copy link
Member

This also includes a SCTK test client, not sure if we want that in the codebase, but I committed it for now, we can just drop the commit as needed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 8.16327% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 20.46%. Comparing base (b62ced7) to head (b33ba0e).

Files Patch % Lines
src/wayland/xdg_foreign/handlers.rs 0.00% 162 Missing ⚠️
src/wayland/xdg_foreign/mod.rs 48.27% 15 Missing ⚠️
anvil/src/state.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   20.55%   20.46%   -0.10%     
==========================================
  Files         158      160       +2     
  Lines       25868    26064     +196     
==========================================
+ Hits         5317     5333      +16     
- Misses      20551    20731     +180     
Flag Coverage Δ
wlcs-buffer 17.89% <8.16%> (-0.08%) ⬇️
wlcs-core 17.55% <8.16%> (-0.08%) ⬇️
wlcs-output 7.53% <8.16%> (+<0.01%) ⬆️
wlcs-pointer-input 19.34% <8.16%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drakulix
Copy link
Member

This also includes a SCTK test client, not sure if we want that in the codebase, but I committed it for now, we can just drop the commit as needed.

I don't think it's harmful, but it might make a better example for SCTK?

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (waiting for a decision regarding the example before merging)

@PolyMeilex PolyMeilex merged commit 8924f6c into Smithay:master Feb 26, 2024
13 checks passed
@PolyMeilex
Copy link
Member Author

PolyMeilex commented Feb 26, 2024

Test client dropped, SCTK sounds like a better place, as there it can serve both as an example and a test client at the same time.

@PolyMeilex PolyMeilex deleted the xdg-foreign branch February 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants