Implement the xwayland shell protocol #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmarc
commented
Mar 2, 2024
colinmarc
force-pushed
the
xwayland-shell
branch
2 times, most recently
from
f227c27 to
64ebcfa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 20.61% 19.49% -1.12%
==========================================
Files 161 161
Lines 26152 26017 -135
==========================================
- Hits 5390 5072 -318
- Misses 20762 20945 +183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Drakulix
reviewed
Mar 4, 2024
colinmarc
commented
Mar 4, 2024
Drakulix
reviewed
Mar 11, 2024
colinmarc
force-pushed
the
xwayland-shell
branch
from
184fd7c to
861dab7
Compare
|
Rebased and removed the anvil hack. This is only blocked on #1350 now (although I could separate it out if you really want). |
Drakulix
reviewed
Apr 15, 2024
colinmarc
force-pushed
the
xwayland-shell
branch
3 times, most recently
from
d7d634c to
73eb19b
Compare
Drakulix
reviewed
Apr 26, 2024
colinmarc
force-pushed
the
xwayland-shell
branch
2 times, most recently
from
8e51e33 to
3c7d41c
Compare
|
CI failures appear unrelated. |
|
CI failure should be fixed by https://github.com/Smithay/smithay/pull/1424/files, can you rebase? |
Drakulix
approved these changes
May 8, 2024
...and use it to associate wl_surfaces to X11 surfaces. The xwayland shell protocol moves the responsibility of setting the "xwayland_surface" role on the wl_surface from the x11 side of the connection to the wayland side. Among other things, this avoids the xwm racing the lifecycle of the surface. Since we can check the serial with a commit hook, this also removes the need for a ugly idle callback in the Xwm, and may allow for better separation of concerns in the future, for example moving the association state tracking out of Xwm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1350 (but only trivially).
The xwayland shell protocol moves the responsibility of setting the "xwayland_surface" role on the wl_surface from the x11 side of the connection to the wayland side. Among other things, this avoids the xwm racing the lifecycle of the surface.
Since we can check the serial with a commit hook, this also removes the need for a ugly idle callback in the
Xwm, and may allow for better separation of concerns in the future, for example moving the association state tracking out of Xwm.Without the idle callback, we may be able to remove the hard dependency on calloop in the xwayland stack (which is my ulterior motive). It's still required for
send_selection- I'll attempt to figure those issues out in another PR.