Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland.xdg_toplevel_icon: Initial implementation #1512

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

PolyMeilex
Copy link
Member

Draft, as it awaits next wayland-protocols release

@PolyMeilex PolyMeilex marked this pull request as draft August 25, 2024 18:32
@PolyMeilex PolyMeilex force-pushed the xdg-icon branch 4 times, most recently from 3e37fe6 to a043e49 Compare August 25, 2024 19:12
@PolyMeilex PolyMeilex force-pushed the xdg-icon branch 2 times, most recently from aeefb7e to b6545af Compare September 1, 2024 17:16
@ids1024
Copy link
Member

ids1024 commented Sep 4, 2024

The wayland-protocols crate is now released, with this protocol.

@PolyMeilex PolyMeilex force-pushed the xdg-icon branch 2 times, most recently from 2670db5 to bef4095 Compare September 4, 2024 20:42
@PolyMeilex PolyMeilex marked this pull request as ready for review September 4, 2024 20:53
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you rebase this to drop the now unnecessary ci.yml/Cargo.toml changes?

@PolyMeilex PolyMeilex merged commit 85268cd into Smithay:master Sep 10, 2024
13 checks passed
@PolyMeilex PolyMeilex deleted the xdg-icon branch September 10, 2024 17:31
@PolyMeilex
Copy link
Member Author

Thanks for the review! And for the wayland-rs version bump. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants