Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdisplay-info integration #1522

Merged
merged 1 commit into from
Sep 10, 2024
Merged

libdisplay-info integration #1522

merged 1 commit into from
Sep 10, 2024

Conversation

cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Aug 31, 2024

Rough integration of libdisplay-info into anvil.

Do we want to provide an easier integration? Maybe replacing edid-rs in smithay-drm-extras?
If yes it might make sense to limit this to returning the Info from libdisplay-info instead of EdidInfo.
Info already has accessor for model/make.

@PolyMeilex @Drakulix @YaLTeR

@YaLTeR
Copy link
Contributor

YaLTeR commented Sep 2, 2024

Do we want to provide an easier integration? Maybe replacing edid-rs in smithay-drm-extras?
If yes it might make sense to limit this to returning the Info from libdisplay-info instead of EdidInfo.
Info already has accessor for model/make.

I think this makes sense. Looking at the rustdoc, there's Info::edid() which seems to get you access to the rest of the information?

@Drakulix
Copy link
Member

Drakulix commented Sep 2, 2024

Rough integration of libdisplay-info into anvil.

Do we want to provide an easier integration? Maybe replacing edid-rs in smithay-drm-extras? If yes it might make sense to limit this to returning the Info from libdisplay-info instead of EdidInfo. Info already has accessor for model/make.

@PolyMeilex @Drakulix @YaLTeR

Agreeing with @YaLTeR here, I think smithay-drm-extras should just return libdisplay_info::Info instead of edid-rs::EdidInfo.

@PolyMeilex
Copy link
Member

PolyMeilex commented Sep 2, 2024

I think smithay-drm-extras should just return libdisplay_info::Info

Sounds good to me, if (sadly) we are going to need C dependency for display info anyways, then there is no need to keep edid-rs around.

@cmeissl cmeissl force-pushed the feature/libdisplay-info branch 3 times, most recently from a7f64e6 to e228617 Compare September 3, 2024 18:44
@cmeissl cmeissl force-pushed the feature/libdisplay-info branch from e228617 to 072df1f Compare September 3, 2024 18:48
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, anything else you want to do with this before it is ready to merge?

@cmeissl cmeissl marked this pull request as ready for review September 10, 2024 12:51
@cmeissl
Copy link
Collaborator Author

cmeissl commented Sep 10, 2024

Looks great, anything else you want to do with this before it is ready to merge?

nope, should be fine as is :)

@Drakulix Drakulix merged commit ba75638 into master Sep 10, 2024
13 checks passed
@Drakulix Drakulix deleted the feature/libdisplay-info branch September 10, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants