Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland.shm: Add support for wl_shm version 2 #1532

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

PolyMeilex
Copy link
Member

Version 2 adds release request, we don't have to do anything with it in Smithay as it is marked as destructor.

Draft until next wayland-rs release

@ids1024
Copy link
Member

ids1024 commented Sep 14, 2024

Nice, I forgot this was added to wayland. Now if only https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/388 could be merged too...

@ids1024
Copy link
Member

ids1024 commented Oct 23, 2024

The new wayland-rs release should have this.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.66%. Comparing base (d5cedee) to head (25416ed).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/wayland/shm/handlers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1532   +/-   ##
=======================================
  Coverage   19.66%   19.66%           
=======================================
  Files         169      169           
  Lines       27749    27810   +61     
=======================================
+ Hits         5456     5468   +12     
- Misses      22293    22342   +49     
Flag Coverage Δ
wlcs-buffer 17.08% <50.00%> (+<0.01%) ⬆️
wlcs-core 16.82% <50.00%> (+<0.01%) ⬆️
wlcs-output 6.89% <50.00%> (-0.02%) ⬇️
wlcs-pointer-input 18.60% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PolyMeilex PolyMeilex marked this pull request as ready for review October 24, 2024 16:54
@Drakulix Drakulix merged commit 6dce628 into Smithay:master Oct 27, 2024
13 checks passed
@PolyMeilex PolyMeilex deleted the wl-shm-2 branch October 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants