-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement XDG-Decoration Protocol #394
Conversation
src/wayland/shell/xdg/mod.rs
Outdated
.get::<self::xdg_handlers::ShellSurfaceUserData>() | ||
.unwrap(); | ||
data.xdg_surface.as_ref().post_error( | ||
xdg_surface::Error::NotConstructed as u32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off topic:
I do wonder, would having the wayland-rs's post_error
take an Into<u32>
reduce the amount of as u32
casts
Would it be possible to also implement |
Poly, my guess for ensuring no existing buffer is attached or commited is get the underlying state of the toplevel's wl_surface and check if some fields on SurfaceData attached to the wl_surface are None or Some? |
For sure, that's my plan, but for another PR, as xdg decoration is based on xdg toplevels, and kde's server decoration is based on wl-surfaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to check this: ...
This part cannot be checked in Smithay given the helper as you provide it, so it'll have to be delegated to either the compositor itself or some future higher-level abstraction.
I'm not sure how to check this: