Fixup for #419 and #421 #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slots with an age of 0 were never rendered to. This means we should not increase their age, when others are submitted or the renderer might wrongfully assume usuable contents are available in the buffer.
The current code always acquires the buffer it just submitted, which results in always rendering to a buffer with age "1", although its contents are older, because the currently held buffer is already submitted, just not to the swapchain. When it finally is submitted its age is again set to 1, the other gets its correct age (but too late) and the circle is repeated again. So lets fix that.
Drakulix
force-pushed
the
fixup/buffer_age
branch
from
a99b1a1 to
bd305dc
Compare
i509VCB
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#419 and #421 brought buffer age support to the x11 backend.
However it is not utilized (yet) by anvil, causing two issues with the implementation to slip through.
#423 uncovered them and these two commits are cherry-picked from that PR to unblock further development of the X11 backend, while #423 is still in flux and will likely need a lot more time.