Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update anvil to show off desktop abstractions #448

Merged
merged 6 commits into from
Feb 7, 2022
Merged

Update anvil to show off desktop abstractions #448

merged 6 commits into from
Feb 7, 2022

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Jan 5, 2022 •
edited
Loading

  • Depends on Desktop abstractions #423. (needs to be merged.)
  • History needs cleanup.
  • RenderDoc support needs to be moved into another PR or flashed out. (Moved to feature/render_doc for now)
  • Output scale changes need fixup.
  • Desktop abstractions need to support XWayland to not downgrade anvils feature set. ("Support" is nothing more than allowing to implement this externally like before.)

PolyMeilex
PolyMeilex reviewed Jan 14, 2022
View reviewed changes
@Drakulix Drakulix force-pushed the anvil/desktop branch 7 times, most recently from 2f02ed0 to 9d804c1 Compare February 6, 2022 18:57
@cmeissl cmeissl mentioned this pull request Feb 6, 2022
Closed
@Drakulix Drakulix marked this pull request as ready for review February 6, 2022 20:17
elinorbgr
elinorbgr approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@elinorbgr elinorbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with the space abstraction to check all the details of the PR, but overall it looks good to me. 👍

@Drakulix Drakulix merged commit 7953287 into master Feb 7, 2022
@Drakulix Drakulix deleted the anvil/desktop branch February 7, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elinorbgr elinorbgr elinorbgr approved these changes

@i509VCB i509VCB Awaiting requested review from i509VCB

@PolyMeilex PolyMeilex Awaiting requested review from PolyMeilex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drakulix @elinorbgr @PolyMeilex