Add client touch capability support #499
Conversation
| pub struct TouchSlot { | ||
| id: u64, | ||
| id: Option<u32>, |
There was a problem hiding this comment.
I've decided to change the TouchSlot here because it already was creating some friction inside my compositor when handling touch events and just created more problems when it came to converting the Option<TouchSlot> back to a i32 to send it to the client.
So since I'd assume nobody is using touch yet (since it doesn't work for clients), changing it now will prevent headaches in the future.
| /// # "seat-0".into(), | ||
| /// # None | ||
| /// # ); | ||
| /// let touch_handle = seat.add_touch(); |
There was a problem hiding this comment.
This example doesn't really explain anything more than the function docs itself.
If the seat creation are made visible it would be more jusitifed to have.
There was a problem hiding this comment.
Correct, but I'd say the same applies for the existing code examples for keyboard/pointer?
If the seat creation are made visible it would be more jusitifed to have.
What do you mean by this? Removing the # before the seat stuff?
|
I've uploaded some videos for the people unable to test with touchscreens (these will be gone in 24h, unfortunately the videos are too big for GH): |
|
Actually, could we get a short changelog entry for this? Quick note about the addition and maybe mention the braking change of touch slot (although I doubt anyone was using it) |
Yep, of course. Was just waiting for feedback on the general design first. |
CHANGELOG.md
Outdated
| @@ -14,6 +14,8 @@ | |||
| - `MouseButton` is now non-exhaustive. | |||
| - Remove `Other` and add `Forward` and `Back` variants to `MouseButton`. Use the new `PointerButtonEvent::button_code` in place of `Other`. | |||
| - `GrabStartData` has been renamed to `PointerGrabStartData` | |||
| - Added `TouchHandle` for Wayland client touch support (see `Seat::get_touch`) | |||
There was a problem hiding this comment.
Technically, this should be under Additions > Clients & Protocols as this is not "Braking Change" per se
There was a problem hiding this comment.
I agree with @PolyMeilex's remarks, but other than that, this is good for merge.
|
@chrisduerr Could you rebase on master? I pushed some fixes to make CI on master green again and would like to verify CI works on this branch as well before merging it. |
While Smithay already supports libinput's touch events, it did not support forwarding touch events to clients yet. This patch implements a new `TouchHandle`, which can be acquired from `Seat::get_touch`.
|
Done. |
|
Thank you! |
While Smithay already supports libinput's touch events, it did not
support forwarding touch events to clients yet.
This patch implements a new
TouchHandle, which can be acquired fromSeat::get_touch.