X11 wm in smithay

[Drakulix]

WIP PR to track progress of implementing a re-parenting xwayland window manager in smithay and integrating it with the desktop module.

[codecov-commenter]

Codecov Report

Base: 25.05% // Head: 25.26% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (81966e1) compared to base (c85e1e5).
Patch coverage: 26.02% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   25.05%   25.26%   +0.21%     
==========================================
  Files         125      130       +5     
  Lines       20174    20867     +693     
==========================================
+ Hits         5055     5273     +218     
- Misses      15119    15594     +475     

Flag	Coverage Δ
wlcs-core	22.65% <23.05%> (+0.09%)	⬆️
wlcs-output	10.38% <2.14%> (-0.23%)	⬇️
wlcs-pointer-input	24.51% <25.52%> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
anvil/src/input_handler.rs	9.02% <0.00%> (-0.27%)	⬇️
src/desktop/space/mod.rs	58.76% <ø> (ø)
anvil/src/shell/grabs.rs	1.70% <1.70%> (ø)
anvil/src/shell/xdg.rs	3.12% <3.12%> (ø)
anvil/src/shell/ssd.rs	9.95% <9.95%> (ø)
anvil/src/focus.rs	16.17% <20.45%> (+0.86%)	⬆️
anvil/src/shell/element.rs	38.19% <38.19%> (ø)
anvil/src/state.rs	37.43% <38.55%> (-0.48%)	⬇️
anvil/src/shell/mod.rs	41.40% <41.40%> (ø)
src/desktop/space/wayland/window.rs	51.30% <50.00%> (-8.70%)	⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Drakulix]

Seems to be good enough to handle simple clients like gedit now.

It is still missing window decorations, but I would rather start incrementally making this better than trying to address it all at once.
Steam and fullscreen games are another thing known not to work properly.

[psychon]

I scrolled through this and focused on X11-specific things. Here's the result. Thus, I ignored most of the code since I do not really know enough Wayland / smithay for this. Hopefully the X11 bits are useful.

[cmeissl]

I tried to review the code itself as I am not experienced with X11 in any way. Left some small nits and questions.

[cmeissl]

LGTM

[PolyMeilex]

I don't see anything obviously wrong codewise. LGTM