Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/opaque regions #659

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Conversation

cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Jul 6, 2022

This PR adds support for opaque regions in the renderer and extends the space to skip damage when applicable

cmeissl added 2 commits July 6, 2022 13:25
the logic surface size may not be equal to
the buffer size of a viewport has been attached
to the surface.
contains_rect had a copy and paste error
@cmeissl cmeissl force-pushed the feature/opaque_regions branch 2 times, most recently from 96fe3ae to 755ecb3 Compare July 6, 2022 11:42
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the missing docs!

@cmeissl cmeissl force-pushed the feature/opaque_regions branch 4 times, most recently from bed438c to eebce85 Compare July 6, 2022 17:10
@cmeissl cmeissl marked this pull request as ready for review July 6, 2022 17:11
@cmeissl cmeissl marked this pull request as draft July 6, 2022 17:16
cmeissl added 4 commits July 6, 2022 19:18
add support for subtracting a rectangle
from another
export the surface opaque regions in the
RendererSurfaceState
the opaque regions are used to reduce the
damage
@cmeissl cmeissl force-pushed the feature/opaque_regions branch from eebce85 to 9f17145 Compare July 6, 2022 17:22
@cmeissl cmeissl marked this pull request as ready for review July 6, 2022 17:22
@Drakulix Drakulix merged commit 704d855 into Smithay:master Jul 6, 2022
@cmeissl cmeissl deleted the feature/opaque_regions branch July 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants