Wayland/virtual keyboard #720
Conversation
Codecov ReportBase: 25.83% // Head: 9.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 25.83% 9.78% -16.05%
==========================================
Files 118 120 +2
Lines 18698 18952 +254
==========================================
- Hits 4831 1855 -2976
- Misses 13867 17097 +3230
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Seems that github actions is not allowing clippy to run properly here? |
Smithay build broke after new wayland-rs 0.30 beta got released, proper fix is #752 |
|
I guess I will wait for that then 🥲 |
There was a problem hiding this comment.
Looks mostly fine from a code point of view, but I am not sure on the behavior from the protocol side.
Seems like keymap handling is real hassle and I don't know, if this is handled in the best way. I would like input from @i509VCB or @PolyMeilex before merging this.
src/input/keyboard/mod.rs
Outdated
| kbd.keymap(KeymapFormat::XkbV1, fd.as_raw_fd(), size as u32) | ||
| }); | ||
| if let Err(e) = res { | ||
| debug!(logger, |
There was a problem hiding this comment.
I think this should rather be a warning
There was a problem hiding this comment.
Should I change this, or merge and create a new shorter pr? 😅
There was a problem hiding this comment.
Figured I might as well 😸
|
Sadly you broke CI now. 😅 |
|
Just a minor hiccup 🙈 |
This adds support for virtual keyboard,
it needs a new version of wayland-protocols-misc for it to be able to be merged. The pr probably needs some reviewing first anyway. ;)edit: Everything is tested and implemented, should be ready :')