Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer: Add glow integration #744

Merged
merged 1 commit into from
Oct 7, 2022
Merged

renderer: Add glow integration #744

merged 1 commit into from
Oct 7, 2022

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Sep 7, 2022

Adds a new GlowRenderer that wraps a Gles2Renderer and additionally exposes a glow::Context on top of the same GL context as the underlying renderer.

Can also be used in conjunction with the MultiRenderer and is purely optional.

@Drakulix Drakulix requested a review from i509VCB September 8, 2022 10:38
@Drakulix Drakulix requested a review from PolyMeilex September 21, 2022 14:14
PolyMeilex
PolyMeilex approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Drakulix Drakulix merged commit e6c2e08 into master Oct 7, 2022
@Drakulix Drakulix mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeissl cmeissl cmeissl left review comments

@PolyMeilex PolyMeilex PolyMeilex approved these changes

@i509VCB i509VCB Awaiting requested review from i509VCB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drakulix @cmeissl @PolyMeilex