Feature/drm planes #760

cmeissl · 2022-09-22T16:14:04Z

Current limitations

~~no support for screen-capture~~ DrmCompositor::render_frame now returns a reference to everything needed to implement screencopy. Additional the returned struct implements functions for blitting the frame to a bound buffer.
~~cursor plane known to not work on nvidia (probably related to not using bo flags Cursor)~~ switched to gbm bo write and offscreen rendering -> works now
~~underlay/primary plane direct-scan out check could be relaxed~~ the primary plane can now be used for direct scan-out in more edge cases

TODO

anvil: use GbmBufferedSurface as a fallback (or compile time feature)? -> The old behavior can be forced by setting the ANVIL_DISABLE_DRM_COMPOSITOR env variable

bwidawsk · 2022-11-30T22:21:16Z

src/backend/drm/renderer/mod.rs

+        mut allocator: A,
+        framebuffer_exporter: F,
+        renderer_formats: HashSet<DrmFormat>,
+        cursor_size: Size<u32, BufferCoords>,


I think cursor_size should be an Option because input/cursor isn't required for all compositors.

The drm renderer currently tries to assign whatever fits on the cursor plane, so technically it is not required to be a cursor element. With the latest changes the cursor plane can be completely disabled by not passing it to the constructor.

src/backend/drm/device/mod.rs

Drakulix

A few remarks on documentation, but otherwise I am really happy how this has turned out.

src/backend/drm/compositor/mod.rs

Drakulix · 2023-02-15T14:02:48Z

src/backend/renderer/mod.rs

+///
+/// *Note*: This will only return y-inverted for buffer types known to smithay (see [`buffer_type`])
+#[cfg(feature = "wayland_frontend")]
+pub fn buffer_y_inverted(buffer: &wl_buffer::WlBuffer) -> Option<bool> {


For what it is worth, the Result is more self-explanatory. (and thus probably the better fit here)

Otherwise the function needs some docs, what None means.

src/backend/drm/compositor/mod.rs

i509VCB · 2023-02-15T17:12:16Z

src/backend/drm/compositor/mod.rs

+//!     None,
+//! );
+//!
+//! # let device: DrmDevice = unsafe { MaybeUninit::uninit().assume_init() };


We should probably just use todo!() here, I'm a little scared by using MaybeUninit here. Plus the example is no_run, so it shouldn't cause any real change.

Yeah, I have also used unreachable!() in those cases.

Oh, I never thought about using just todo!() and always used some obscure ways, thanks!

this allows storing the buffer for a plane to prevent early release

this remove the External variant of UnderlyingStorage, exposing the TextureId is of no use

debug flags can be enabled at run-time for a renderer for now the only supported flag is TINT which will TINT all rendered textures

this increases api ergonomics for the damage tracker by using IntoIterator instead of a slice

this adds a plane config and state in order to make a complete plane test

this changes Rectangle::overlaps to no longer return true for touching rectangles. the old behavior can be found in Rectangle::overlaps_or_touches

the compositor makes use of overlay and cursor planes to enable direct scan-out

cmeissl mentioned this pull request Sep 23, 2022

Split rendering code from Space and make it generic #727

Merged

4 tasks

Drakulix force-pushed the dev/space-renderer-split branch from 25e70a2 to 5caa01a Compare September 23, 2022 17:00

cmeissl force-pushed the feature/drm_planes branch 2 times, most recently from b23c15c to fe0a6a7 Compare October 3, 2022 11:22

Drakulix force-pushed the dev/space-renderer-split branch 4 times, most recently from df4e3d9 to 7aeda28 Compare October 5, 2022 16:12

Drakulix force-pushed the dev/space-renderer-split branch from a487b58 to 353a96a Compare October 11, 2022 16:00

cmeissl force-pushed the feature/drm_planes branch from fe0a6a7 to f8ccbcc Compare October 15, 2022 13:18

cmeissl force-pushed the feature/drm_planes branch from f8ccbcc to d93d3f6 Compare November 8, 2022 15:26

cmeissl force-pushed the feature/drm_planes branch from d93d3f6 to b86be50 Compare November 17, 2022 16:47

cmeissl changed the base branch from dev/space-renderer-split to master November 17, 2022 16:51

cmeissl force-pushed the feature/drm_planes branch 10 times, most recently from 19c79e7 to 31ac6d2 Compare November 25, 2022 09:18

bwidawsk reviewed Nov 30, 2022

View reviewed changes

atseanpaul reviewed Dec 12, 2022

View reviewed changes

src/backend/drm/device/mod.rs Outdated Show resolved Hide resolved

cmeissl force-pushed the feature/drm_planes branch 5 times, most recently from cfa27cb to a01ace6 Compare December 16, 2022 20:16

cmeissl force-pushed the feature/drm_planes branch 2 times, most recently from dafdfee to 5b969e9 Compare February 15, 2023 14:40

Drakulix reviewed Feb 15, 2023

View reviewed changes

cmeissl force-pushed the feature/drm_planes branch from 5b969e9 to f9f07ef Compare February 15, 2023 16:36

Drakulix approved these changes Feb 15, 2023

View reviewed changes

src/backend/drm/compositor/mod.rs Outdated Show resolved Hide resolved

src/backend/drm/compositor/mod.rs Outdated Show resolved Hide resolved

src/backend/drm/compositor/mod.rs Outdated Show resolved Hide resolved

src/backend/drm/compositor/mod.rs Outdated Show resolved Hide resolved

cmeissl force-pushed the feature/drm_planes branch from f9f07ef to ef45693 Compare February 15, 2023 16:54

i509VCB reviewed Feb 15, 2023

View reviewed changes

cmeissl force-pushed the feature/drm_planes branch from ef45693 to 19385b1 Compare February 15, 2023 17:21

cmeissl added 14 commits February 15, 2023 18:40

utils: remove bogus PartialCmp for Size

7d5922c

renderer: add util function for y-inverted buffers

b7cf02b

renderer: ref counting for wayland buffer release

f359edd

this allows storing the buffer for a plane to prevent early release

renderer: remove UnderlyingStorage::External

ff60600

this remove the External variant of UnderlyingStorage, exposing the TextureId is of no use

drm: cursor size is in Buffer Coordinates

c4946ba

renderer: fix returned damage from dtr

fb3bce5

renderer: introduce debug flags

699b303

debug flags can be enabled at run-time for a renderer for now the only supported flag is TINT which will TINT all rendered textures

renderer: make the damage tracker take an iterator

7836395

this increases api ergonomics for the damage tracker by using IntoIterator instead of a slice

drm: expose the DrmDeviceFd of the surface

e8c48df

drm: allow to test a complete plane state

75c614d

this adds a plane config and state in order to make a complete plane test

drm: return an error if plane test fails

8a1681a

drm: allow to claim a specific plane on an crtc

c8212ec

drm: expose the plane zpos

b3347ee

utils: provide a overlaps or touches variant

7b32864

this changes Rectangle::overlaps to no longer return true for touching rectangles. the old behavior can be found in Rectangle::overlaps_or_touches

cmeissl force-pushed the feature/drm_planes branch from 19385b1 to 7c6a949 Compare February 15, 2023 17:40

cmeissl added 4 commits February 15, 2023 18:48

drm: add a specialized drm compositor

09d3037

the compositor makes use of overlay and cursor planes to enable direct scan-out

anvil: make use of the new DrmCompositor

10c2709

anvil: skip overlay planes for nvidia

0b4e98f

anvil: add debug impls for render elements

e0d2584

cmeissl force-pushed the feature/drm_planes branch from 7c6a949 to e0d2584 Compare February 15, 2023 17:49

Drakulix merged commit 16ef29e into Smithay:master Feb 15, 2023

ids1024 mentioned this pull request Feb 24, 2023

Anvil crashing on tty switch off of it and back #907

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/drm planes #760

Feature/drm planes #760

cmeissl commented Sep 22, 2022 •

edited

Loading

bwidawsk Nov 30, 2022 •

edited

Loading

cmeissl Dec 23, 2022

Drakulix left a comment

Drakulix Feb 15, 2023

i509VCB Feb 15, 2023

Drakulix Feb 15, 2023

cmeissl Feb 15, 2023

Feature/drm planes #760

Feature/drm planes #760

Conversation

cmeissl commented Sep 22, 2022 • edited Loading

Current limitations

TODO

bwidawsk Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

cmeissl Dec 23, 2022

Choose a reason for hiding this comment

Drakulix left a comment

Choose a reason for hiding this comment

Drakulix Feb 15, 2023

Choose a reason for hiding this comment

i509VCB Feb 15, 2023

Choose a reason for hiding this comment

Drakulix Feb 15, 2023

Choose a reason for hiding this comment

cmeissl Feb 15, 2023

Choose a reason for hiding this comment

cmeissl commented Sep 22, 2022 •

edited

Loading

bwidawsk Nov 30, 2022 •

edited

Loading