Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fractional scale #840

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Conversation

cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Dec 18, 2022

This PR add support for wp_fractional_scale, rounding should be good for toplevel surfaces.
The rounding for subsurface position and size is explicitely undefined in the spec, so it should be
fine for now as is I guess.

Testing done with single-surface from updated test-clients

depends on wayland-rs#590 merged

@cmeissl cmeissl force-pushed the feature/fractional_scale branch from 10980cd to 705c5f4 Compare December 18, 2022 21:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 24.78% // Head: 24.57% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (705c5f4) compared to base (91518e9).
Patch coverage: 10.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   24.78%   24.57%   -0.22%     
==========================================
  Files         124      125       +1     
  Lines       19969    20248     +279     
==========================================
+ Hits         4949     4975      +26     
- Misses      15020    15273     +253     
Flag Coverage Δ
wlcs-core 22.52% <10.93%> (-0.20%) ⬇️
wlcs-output 9.70% <10.41%> (-0.04%) ⬇️
wlcs-pointer-input 24.35% <10.93%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/desktop/wayland/utils.rs 45.24% <0.00%> (-0.15%) ⬇️
anvil/src/state.rs 37.91% <3.50%> (-6.42%) ⬇️
src/wayland/fractional_scale/mod.rs 13.74% <13.74%> (ø)
anvil/src/shell.rs 14.93% <100.00%> (ø)
src/lib.rs 24.50% <0.00%> (-75.50%) ⬇️
src/backend/renderer/damage.rs 67.18% <0.00%> (-3.36%) ⬇️
build.rs 78.94% <0.00%> (-1.06%) ⬇️
src/output.rs 68.91% <0.00%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmeissl cmeissl force-pushed the feature/fractional_scale branch 2 times, most recently from e3b3ca5 to c260818 Compare December 19, 2022 09:58
@cmeissl cmeissl force-pushed the feature/fractional_scale branch from c260818 to 1c4ddd9 Compare December 20, 2022 21:20
@cmeissl cmeissl force-pushed the feature/fractional_scale branch from 1c4ddd9 to e71213c Compare December 20, 2022 21:22
@cmeissl cmeissl marked this pull request as ready for review December 20, 2022 21:25
@Drakulix Drakulix merged commit 0d9d68d into Smithay:master Dec 21, 2022
@cmeissl cmeissl deleted the feature/fractional_scale branch December 21, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants