Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gles2: custom shaders #901

Merged
merged 16 commits into from
Mar 20, 2023
Merged

gles2: custom shaders #901

merged 16 commits into from
Mar 20, 2023

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Feb 22, 2023

Adds first-party support for shader-based render elements.

Refactors a few things in the process:

  • Combines our three fragment texture shaders into one and compiles it multiple times with corresponding #defines.
  • Adds another debug shader permutation for debug_flags

TODO:

  • Add the same option for custom texture shaders
  • Add custom-texture-shader RenderElement wrapper

@Drakulix Drakulix force-pushed the feature/pixel_shaders branch 2 times, most recently from 1858b60 to 50d9d67 Compare February 22, 2023 21:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7fcc80a) 23.81% compared to head (c227847) 23.81%.

❗ Current head c227847 differs from pull request most recent head e949a02. Consider uploading reports for the commit e949a02 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   23.81%   23.81%           
=======================================
  Files         131      131           
  Lines       20810    20810           
=======================================
  Hits         4955     4955           
  Misses      15855    15855           
Flag Coverage Δ
wlcs-core 20.90% <ø> (ø)
wlcs-output 8.94% <ø> (ø)
wlcs-pointer-input 23.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PolyMeilex
Copy link
Member

If our shaders are now nicely combined, would it make sense to move them to .vert, .frag files, and include_str! them, to get proper syntax highlighting and editor support?

@Drakulix
Copy link
Member Author

If our shaders are now nicely combined, would it make sense to move them to .vert, .frag files, and include_str! them, to get proper syntax highlighting and editor support?

Sure thing 596c4d0

@Drakulix Drakulix force-pushed the feature/pixel_shaders branch from 596c4d0 to 15126bf Compare February 23, 2023 13:57
@Drakulix Drakulix changed the title gles2: custom pixel shaders gles2: custom shaders Feb 23, 2023
@Drakulix Drakulix force-pushed the feature/pixel_shaders branch from 15126bf to 0180f5e Compare February 23, 2023 16:50
@Drakulix Drakulix force-pushed the feature/pixel_shaders branch 3 times, most recently from bb55c7d to 03c5dcd Compare February 24, 2023 23:35
@Drakulix Drakulix force-pushed the feature/pixel_shaders branch from 5a15186 to bbeb03e Compare March 3, 2023 17:37
Copy link
Collaborator

@cmeissl cmeissl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that approach and the flexibility it introduces 👍

@Drakulix Drakulix added this to the v0.4: Gathering raw ores milestone Mar 7, 2023
@Drakulix Drakulix mentioned this pull request Mar 14, 2023
@Drakulix Drakulix force-pushed the feature/pixel_shaders branch from bbeb03e to c227847 Compare March 20, 2023 11:16
@Drakulix Drakulix force-pushed the feature/pixel_shaders branch from c227847 to e949a02 Compare March 20, 2023 11:31
@Drakulix Drakulix requested a review from cmeissl March 20, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants