-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DRM abstractions crate #924
Conversation
062c3d5
to
e89f595
Compare
First impression from me are, that this is a super nice cleanup. This also introduces a good place to add further connector metadata processing the future. (Looking a
The trait looks very versatile, I don't necessarily see anything wrong with it
Yes, that is hardware output mirroring. Doing it in software is also possible either by
So while I like the current approach, we probably want a more complete @i509VCB Was thinking about doing an extra crate for |
34c58bc
to
3016bb8
Compare
This is now ready, except for gbm.rs release |
3016bb8
to
4eae710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the premise of switching to stable gbm.rs.
0.12 release is currently in the CI pipeline: https://github.com/Smithay/gbm.rs/actions/runs/4563939258
4eae710
to
1e7c63f
Compare
Smithay DRM Extras
This crate contains some extra abstractions and helpers over DRM
edid
module is responsible for extraction of information from DRM connectors (for nowmodel
andmanufacturer
)drm_scanner
module contains helpers for detecting connector connected and disconnected events as well as mapping crtc to them.ConnectorScanner
is responsible for tracking connected/disconnected events.CrtcMapper
trait andSimpleCrtcMapper
are meant for mapping crtc to connector.DrmScanner<CrtcMapper>
combines two above into single abstraction. If it does not fit your needs you can always drop down to usingConnectoScanner
alone.For envisioned usage, see
smithay-drm-extras/examples/simple.rs
Anvil Changes
Draft
Because it has no docs whatsoeverI'm happy with connector scanner, but I'm still not sure if I like crtc mapper trait, or in general how it is used in DrmScanner (it should be possible to do multiple connectors per drm surface using it, but it might become annoying, not sure how common it is, is that meant for output mirroring?"