Redshifted motion handling #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attipaci
force-pushed
the
redshifted-objects
branch
from
6cd44cd to
2435f0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.2.0 #57 +/- ##
=========================================
Coverage ? 99.64%
=========================================
Files ? 6
Lines ? 2802
Branches ? 539
=========================================
Hits ? 2792
Misses ? 0
Partials ? 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
attipaci
added a commit
that referenced
this pull request
Aug 19, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 19, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 20, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 20, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 20, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 20, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 24, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Aug 29, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Aug 29, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 1, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 1, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 4, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 4, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 11, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 11, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 15, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 15, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 15, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 15, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Sep 19, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Sep 19, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
attipaci
added a commit
that referenced
this pull request
Oct 28, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Oct 28, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
Merged
attipaci
added a commit
that referenced
this pull request
Nov 6, 2024
* A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines.
attipaci
added a commit
that referenced
this pull request
Nov 6, 2024
* Redshifted motion handling (#57) * A corrected version ref in README * Another reference to API documentation in README * Small edits to README * Shoft release schedule up to imporve Fedora package integration * Add redshift handling routines. * Add functions to apply/adjust gravitational redshift for radial velocities. * Tweaks and redshift_add() function * Tweaks * Added novas_z_inv() * Further tweaks * small edits to error handling * various fixes * Small arithmetic simplification * Doxygen edits * Test cases for redshift functions * Split out util.c * test/Makefile: Fix bad rebase * merge util.c -> super.c * super.c: Delete empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, sidereal (i.e. catalog) sources were defined with parameters typical for stars in our Galaxy. As such, motion was parametrized by radial velocity (in line of sight) , as well as proper motion. And, as a result, NOVAS did not offer proper support for handling distant quasars or galaxies, where line-of-sight motion is more typically parameterized with a redshift (z) instead.
Thus we now add:
novas_z2v()to convert redshift values (z) to an equivalent radial velocity (in km/s).novas_v2z()to convert radial velocity values(in km/s) to an equivalent redshift (z).make_redshifted_object()to simplify the initialization of distant sources parameterized by redshift. It will set proper motion and parallax to zero, and initialized the source catalog toEXTto indicate an extragalactic source. (The user may then override the initial values, if necessary).