Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ab tweaks #55

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Feat/ab tweaks #55

merged 3 commits into from
Mar 21, 2024

Conversation

w84april
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smoldapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 2:42pm

Comment on lines 24 to 49
const {set_curtainStatus, dispatchConfiguration} = useAddressBookCurtain();

const getAddressBookButton = useCallback(
(title: string): JSX.Element => {
return (
<button
className={'font-bold transition-all'}
onClick={() => {
set_curtainStatus({isOpen: true, isEditing: true});
dispatchConfiguration({
type: 'SET_SELECTED_ENTRY',
payload: {
address: configuration.receiver.address,
label: '',
slugifiedLabel: '',
chains: [],
isFavorite: false
}
});
}}>
{title}
</button>
);
},
[configuration.receiver.address, dispatchConfiguration, set_curtainStatus]
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit for later: this should be another component, this way we don't import useAddressBookCurtain here and prevent some rerender here

@w84april w84april merged commit 9d76267 into feat/disperse Mar 21, 2024
2 checks passed
@w84april w84april deleted the feat/ab-tweaks branch March 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants