Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Recreate deployment strategy type #123

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Use the Recreate deployment strategy type #123

merged 2 commits into from
Aug 13, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Aug 13, 2024 •
edited
Loading

Resolves #121

Scope

Implemented:

  • The Arcane.Operator deployment will use the Recreate deployment strategy to avoid duplication of the operator in one cluster.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@github-actions GitHub Actions
Copy link

Coverage after merging recreate-deployment into main will be

73.34%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Extensions
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs100%100%100%100%
   V1JobExtensions.cs76.97%59.09%88.24%83.52%105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 52–53, 53, 53, 53, 53–55, 58–59, 68, 68, 75, 83–84, 84, 84, 84, 84–87
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs75%100%75%75%29–30
src/Models/Commands
   StreamClassCommands.cs100%100%100%100%
   StreamDefinitionCommands.cs89.74%100%92.86%88%126–128
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs47.89%16.67%75%49.18%39–42, 59–62, 67–71, 71, 71–78, 78, 78–90
   StreamingJobCommandHandler.cs86.46%66.67%100%90.28%111, 111, 114, 50, 54, 57, 60, 83–88
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs85.29%100%75%85.71%50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs57.14%25%66.67%58.14%42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%104, 106, 81, 81, 85
   StreamingJobOperatorService.cs69.93%57.14%85.71%74.04%100–106, 141–145, 150, 154, 154, 154, 159–160, 78, 78, 78, 80, 83, 88–91, 91, 91–93, 93, 93, 93, 93–99, 99, 99, 99, 99
   StreamOperatorService.cs80%66.07%90.91%84.62%107–111, 156–157, 157, 157, 159–160, 169, 177–181, 197, 199, 203, 203, 203, 209–210, 76–77, 77, 77–78, 91–92, 92, 92, 92, 92, 92, 92–95, 97
src/Services/Repositories/CustomResources
   StreamClassRepository.cs92.86%50%100%95.45%30, 32
   StreamDefinitionRepository.cs0%100%0%0%21–24, 29–34, 36–39, 42–49, 51–52, 56–61
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–54
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

@github-actions GitHub Actions
Copy link

Coverage after merging recreate-deployment into main will be

73.34%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Extensions
   KubernetesObjectExtensions.cs100%100%100%100%
   StreamClassPhaseExtensions.cs100%100%100%100%
   V1JobExtensions.cs76.97%59.09%88.24%83.52%105, 105, 126, 126, 131, 136, 136, 141, 146, 146, 151, 52–53, 53, 53, 53, 53–55, 58–59, 68, 68, 75, 83–84, 84, 84, 84, 84–87
src/Models/Api
   CustomResourceApiRequest.cs100%100%100%100%
   ResourceEvent.cs100%100%100%100%
src/Models/Base
   KubernetesCommands.cs75%100%75%75%29–30
src/Models/Commands
   StreamClassCommands.cs100%100%100%100%
   StreamDefinitionCommands.cs89.74%100%92.86%88%126–128
   StreamingJobCommands.cs100%100%100%100%
src/Models/Resources/Status/V1Alpha1
   V1Alpha1StreamStatus.cs100%100%100%100%
src/Models/Resources/StreamClass/V1Beta1
   V1Beta1StreamClassSpec.cs85.71%100%85.71%85.71%12
src/Models/Resources/StreamDefinitions/Base
   IStreamDefinition.cs90%83.33%100%100%29
src/Services/CommandHandlers
   AnnotationCommandHandler.cs47.89%16.67%75%49.18%39–42, 59–62, 67–71, 71, 71–78, 78, 78–90
   StreamingJobCommandHandler.cs86.46%66.67%100%90.28%111, 111, 114, 50, 54, 57, 60, 83–88
   UpdateStatusCommandHandler.cs91.14%75%100%91.43%102–103, 44–47, 85
src/Services/HostedServices
   HostedStreamingJobOperatorService.cs0%0%0%0%16–24, 27–29, 29, 29–36, 39–42
src/Services/Metrics
   DeclaredMetrics.cs67.65%60%75%70%26–31, 33, 33, 33, 33
   MetricsReporter.cs85.29%100%75%85.71%50–53
src/Services/Metrics/Actors
   MetricsPublisherActor.cs57.14%25%66.67%58.14%42, 48, 53, 72–78, 82–83, 83, 83–86, 92–95
src/Services/Operators
   StreamClassOperatorService.cs93.06%62.50%100%96.55%104, 106, 81, 81, 85
   StreamingJobOperatorService.cs69.93%57.14%85.71%74.04%100–106, 141–145, 150, 154, 154, 154, 159–160, 78, 78, 78, 80, 83, 88–91, 91, 91–93, 93, 93, 93, 93–99, 99, 99, 99, 99
   StreamOperatorService.cs80%66.07%90.91%84.62%107–111, 156–157, 157, 157, 159–160, 169, 177–181, 197, 199, 203, 203, 203, 209–210, 76–77, 77, 77–78, 91–92, 92, 92, 92, 92, 92, 92–95, 97
src/Services/Repositories/CustomResources
   StreamClassRepository.cs92.86%50%100%95.45%30, 32
   StreamDefinitionRepository.cs0%100%0%0%21–24, 29–34, 36–39, 42–49, 51–52, 56–61
   StreamingJobTemplateRepository.cs0%0%0%0%21–28, 32–34, 34, 34, 34, 34, 34, 34, 34, 34–37, 40–54
src/Services/Repositories/StreamingJob
   StreamingJobRepository.cs58.82%100%66.67%57.14%33–38

@s-vitaliy s-vitaliy marked this pull request as ready for review August 13, 2024 12:34
@s-vitaliy s-vitaliy requested a review from a team as a code owner August 13, 2024 12:34
@s-vitaliy s-vitaliy merged commit ca2f03b into main Aug 13, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the recreate-deployment branch August 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinag08 adelinag08 adelinag08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use the Recreate deployment strategy
2 participants
@s-vitaliy @adelinag08