Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cdm change feed stream runner #26

Merged
merged 12 commits into from
Aug 5, 2024
Merged

Add Cdm change feed stream runner #26

merged 12 commits into from
Aug 5, 2024

Conversation

adelinag08
Copy link
Contributor

@adelinag08 adelinag08 commented Jul 23, 2024 •
edited
Loading

Part of #7

Scope

Implemented:

  • Add CDM feed stream implementation using Arcane.Framework

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@github-actions GitHub Actions
Copy link

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%20–34, 37–40
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%12, 17, 22, 27, 32, 37, 42, 47, 52, 57, 60–62
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8
src/Services
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41

@github-actions GitHub Actions
Copy link

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%22–37, 41–45
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%12, 17, 22, 27, 32, 37, 42, 47, 52, 57, 60–62
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8
src/Services
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41

@github-actions GitHub Actions
Copy link

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%22–37, 41–45
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%12, 17, 22, 27, 32, 37, 42, 47, 52, 57, 60–62
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8
src/Services
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%22–37, 41–45
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%12, 17, 22, 27, 32, 37, 42, 47, 52, 57, 60–62
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8
src/Services
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%22–37, 41–45
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%11, 16, 21, 26, 31, 36, 41, 44–46
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8
src/Services
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–30, 30, 30–51, 54–56, 58
src/Extensions
   CdmChangeFeedSourceExtension.cs0%100%0%0%22–37, 41–45
src/GraphBuilder
   CdmChangeFeedGraphBuilder.cs0%0%0%0%19–23, 26–27, 27, 27–34, 37–41
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%11, 16, 21, 26, 31, 36, 41, 44–46
src/Models/Base
   CdmChangeFeedContextBase.cs0%100%0%0%11, 14, 18–20, 24–26, 30–32, 8

@adelinag08 adelinag08 marked this pull request as ready for review August 5, 2024 11:22
@adelinag08 adelinag08 requested a review from a team as a code owner August 5, 2024 11:22
s-vitaliy
s-vitaliy requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a bit more work

src/Extensions/CdmChangeFeedSourceExtension.cs Outdated Show resolved Hide resolved
src/Program.cs Outdated Show resolved Hide resolved
src/Program.cs Outdated Show resolved Hide resolved
src/GraphBuilder/CdmChangeFeedGraphBuilder.cs Outdated Show resolved Hide resolved
src/Models/Base/CdmChangeFeedContextBase.cs Outdated Show resolved Hide resolved
src/Models/CdmChangeFeedStreamContext.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%100%0%0%14, 18–35, 38–40, 42
src/GraphBuilder
   CdmChangeFeedGraphBuilder.cs0%0%0%0%24–30, 33–36, 38–51, 56–57, 57, 57–62, 64–65
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%13, 18, 25, 30, 35, 40, 45, 48, 51, 54, 58–60, 64–66, 70–72

s-vitaliy
s-vitaliy approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler now :)

src/Program.cs Outdated Show resolved Hide resolved
src/GraphBuilder/CdmChangeFeedGraphBuilder.cs Outdated Show resolved Hide resolved
s-vitaliy
s-vitaliy approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@s-vitaliy s-vitaliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also properties for dashboard

src/Program.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%100%0%0%14, 18–37, 40–42, 44
src/GraphBuilder
   CdmChangeFeedGraphBuilder.cs0%0%0%0%24–30, 33–36, 38–52, 57–58, 58, 58–63, 65–66
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%13, 18, 25, 30, 35, 40, 45, 48, 51, 54, 58–60, 64–66, 70–72

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Coverage after merging cdm-feed into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%100%0%0%14, 18–37, 40–42, 44
src/GraphBuilder
   CdmChangeFeedGraphBuilder.cs0%0%0%0%24–30, 33–36, 38–52, 57–58, 58, 58–63, 65–66
src/Models
   CdmChangeFeedStreamContext.cs0%100%0%0%13, 18, 25, 30, 35, 40, 45, 48, 51, 54, 58–60, 64–66, 70–72

@adelinag08 adelinag08 merged commit 720785e into main Aug 5, 2024
2 checks passed
@adelinag08 adelinag08 deleted the cdm-feed branch August 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-vitaliy s-vitaliy s-vitaliy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adelinag08 @s-vitaliy