Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect reading the changeCaptureIntervalSeconds property #64

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix incorrect reading the changeCaptureIntervalSeconds property #64

merged 3 commits into from
Aug 1, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Aug 1, 2024 •
edited
Loading

URGENT: Fixes the incorrect ChangeCaptureInterval property in Arcane streams.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner August 1, 2024 08:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Coverage after merging fix-incorrect-change-capture-interval-seconds-reading into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–34, 34, 34–53, 56–58, 60
src/Extensions
   RestApiSourceExtensions.cs0%0%0%0%29–43, 47–48, 48, 48–55
src/Models
   RestApiDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 30, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiPagedDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 79, 84, 89, 94
   RestApiPagedFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 79, 84, 89, 94
src/Models/Base
   RestApiDynamicAuthBase.cs0%100%0%0%10, 15, 20, 25, 30, 35, 40, 45, 50, 56, 59–71
   RestApiFixedAuthBase.cs0%100%0%0%10, 13–16
   RestApiStreamContextBase.cs0%0%0%0%13, 16, 19, 23–25, 29–31, 35–37, 42, 45, 45, 45–46, 48–50, 50, 50–52, 55–56
src/Services
   RestApiGraphBuilder.cs0%0%0%0%100–103, 103, 103, 103, 103–105, 105, 105–117, 117, 117–134, 136–147, 150–152, 152, 152, 152, 152–169, 171–176, 178–179, 181–192, 195–202, 204–205, 207–218, 27–31, 34–35, 35, 35, 35, 35, 35, 35, 35, 35–67, 70–80, 82–93, 96–99

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Coverage after merging fix-incorrect-change-capture-interval-seconds-reading into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–34, 34, 34–53, 56–58, 60
src/Extensions
   RestApiSourceExtensions.cs0%0%0%0%29–43, 47–48, 48, 48–55
src/Models
   RestApiDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 30, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiPagedDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 78, 83, 88, 93
   RestApiPagedFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 78, 83, 88, 93
src/Models/Base
   RestApiDynamicAuthBase.cs0%100%0%0%10, 15, 20, 25, 30, 35, 40, 45, 50, 56, 59–71
   RestApiFixedAuthBase.cs0%100%0%0%10, 13–16
   RestApiStreamContextBase.cs0%0%0%0%13, 16, 19, 23–25, 29–31, 35–37, 42, 45, 45, 45–46, 48–50, 50, 50–52, 55–56
src/Services
   RestApiGraphBuilder.cs0%0%0%0%100–103, 103, 103, 103, 103–105, 105, 105–117, 117, 117–134, 136–147, 150–152, 152, 152, 152, 152–169, 171–176, 178–179, 181–192, 195–202, 204–205, 207–218, 27–31, 34–35, 35, 35, 35, 35, 35, 35, 35, 35–67, 70–80, 82–93, 96–99

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Coverage after merging fix-incorrect-change-capture-interval-seconds-reading into main will be

0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Program.cs0%0%0%0%17, 21–34, 34, 34–53, 56–58, 60
src/Extensions
   RestApiSourceExtensions.cs0%0%0%0%29–43, 47–48, 48, 48–55
src/Models
   RestApiDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 30, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 52, 57, 62, 67, 73, 78, 83, 88
   RestApiPagedDynamicAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 78, 83, 88, 93
   RestApiPagedFixedAuthStreamContext.cs0%100%0%0%14, 19, 24, 29, 35, 40, 45, 50, 57, 62, 67, 72, 78, 83, 88, 93
src/Models/Base
   RestApiDynamicAuthBase.cs0%100%0%0%10, 15, 20, 25, 30, 35, 40, 45, 50, 56, 59–71
   RestApiFixedAuthBase.cs0%100%0%0%10, 13–16
   RestApiStreamContextBase.cs0%0%0%0%13, 16, 19, 23–25, 29–31, 35–37, 42, 45, 45, 45–46, 48–50, 50, 50–52, 55–56
src/Services
   RestApiGraphBuilder.cs0%0%0%0%100–103, 103, 103, 103, 103–105, 105, 105–117, 117, 117–134, 136–147, 150–152, 152, 152, 152, 152–169, 171–176, 178–179, 181–192, 195–202, 204–205, 207–218, 27–31, 34–35, 35, 35, 35, 35, 35, 35, 35, 35–67, 70–80, 82–93, 96–99

@s-vitaliy s-vitaliy merged commit 52c3f2a into main Aug 1, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the fix-incorrect-change-capture-interval-seconds-reading branch August 1, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinag08 adelinag08 adelinag08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-vitaliy @adelinag08