Skip to content

Commit

Permalink
Code review suggestions (finos#100)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-lfallasavendano committed Jan 8, 2024
1 parent 25f87a3 commit 8e709dd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions src/Morphir/Snowpark/Customization.elm
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ loadCustomizationOptions optionsDict =
optsList
|> List.filterMap (\(id, value) ->
case id of
ValueID fullName _ -> Just (fullName, value)
_ -> Nothing)
ValueID fullName _ ->
Just (fullName, value)
_ ->
Nothing)
(functionsToCache, valuesToInline) =
functions
|> List.foldr
Expand Down
2 changes: 1 addition & 1 deletion src/Morphir/Snowpark/RecordWrapperGenerator.elm
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ emptyDataFrameMethod =
, typeArgs = []
, args = [ [ arg ] ]
, returnType = Just <| typeRefForSnowparkType "DataFrame"
, body = Just getOrElseUpdateCall -- <| Scala.Apply createDataFrameMethod createDataFrameArgs
, body = Just getOrElseUpdateCall
})

objectForRecordWrapper : Name -> (List (Field ())) -> MappingContextInfo () -> (Scala.Documented (Scala.Annotated Scala.TypeDecl))
Expand Down

0 comments on commit 8e709dd

Please sign in to comment.